From: "David S. Miller" <davem@davemloft.net>
To: arjan@infradead.org
Cc: tedu@coverity.com, linux-kernel@vger.kernel.org, ralf@linux-mips.org
Subject: Re: some missing spin_unlocks
Date: Tue, 23 Aug 2005 10:46:40 -0700 (PDT) [thread overview]
Message-ID: <20050823.104640.25158087.davem@davemloft.net> (raw)
In-Reply-To: <1124818806.3218.20.camel@laptopd505.fenrus.org>
From: Arjan van de Ven <arjan@infradead.org>
Subject: Re: some missing spin_unlocks
Date: Tue, 23 Aug 2005 19:40:06 +0200
> On Tue, 2005-08-23 at 10:30 -0700, David S. Miller wrote:
> > From: Arjan van de Ven <arjan@infradead.org>
> > Date: Tue, 23 Aug 2005 18:54:03 +0200
> >
> > > does it matter? can ANYTHING be spinning on the lock? if not .. can we
> > > just let the lock go poof and not unlock it...
> >
> > I believe socket lookup can, otherwise the code is OK as-is.
>
> lookup while the object is in progress of being destroyed sounds really
> bad though....
This happens all the time with TCP sockets, for example.
When we're trying to kill off a socket which is in time
wait state, the receive path can find it, grab a reference,
and process a packet against it right as we're trying to
kill it off.
This is completely normal.
next prev parent reply other threads:[~2005-08-23 17:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-08-22 22:26 Ted Unangst
2005-08-23 16:46 ` David S. Miller
2005-08-23 16:54 ` Arjan van de Ven
2005-08-23 17:30 ` David S. Miller
2005-08-23 17:40 ` Arjan van de Ven
2005-08-23 17:46 ` David S. Miller [this message]
2005-08-24 15:56 ` Lee Revell
2005-08-24 17:01 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050823.104640.25158087.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=arjan@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ralf@linux-mips.org \
--cc=tedu@coverity.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome