From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932153AbVHWMgE (ORCPT ); Tue, 23 Aug 2005 08:36:04 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932154AbVHWMgD (ORCPT ); Tue, 23 Aug 2005 08:36:03 -0400 Received: from mx2.mail.elte.hu ([157.181.151.9]:1763 "EHLO mx2.mail.elte.hu") by vger.kernel.org with ESMTP id S932153AbVHWMgD (ORCPT ); Tue, 23 Aug 2005 08:36:03 -0400 Date: Tue, 23 Aug 2005 14:36:12 +0200 From: Ingo Molnar To: Steven Rostedt Cc: linux-kernel@vger.kernel.org, Thomas Gleixner , "Paul E. McKenney" Subject: Re: 2.6.13-rc6-rt9 Message-ID: <20050823123612.GA7924@elte.hu> References: <20050818060126.GA13152@elte.hu> <1124433586.5186.119.camel@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1124433586.5186.119.camel@localhost.localdomain> User-Agent: Mutt/1.4.2.1i X-ELTE-SpamScore: 0.0 X-ELTE-SpamLevel: X-ELTE-SpamCheck: no X-ELTE-SpamVersion: ELTE 2.0 X-ELTE-SpamCheck-Details: score=0.0 required=5.9 tests=AWL autolearn=disabled SpamAssassin version=3.0.4 0.0 AWL AWL: From: address is in the auto white-list X-ELTE-VirusStatus: clean Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org * Steven Rostedt wrote: > Ingo, can't you get rt.c to be more confusing. I mean it is too > simple. We need to add a few more underscores here and there :-) > Seriously, that rt.c is mind boggling. It was nice before, now it is > just screaming for a cleanup (come now, do we really need the four > underscores?). Same with latency.c. i agree that it's ugly, but some of that ugliness is to achieve the 7-instructions fail-through codepath for the common acquire (and release) codepath: c03a5320 <__down_mutex>: c03a5320: 89 c1 mov %eax,%ecx c03a5322: 8b 15 08 76 3a c0 mov 0xc03a7608,%edx c03a5328: 31 c0 xor %eax,%eax c03a532a: 0f b1 51 14 cmpxchg %edx,0x14(%ecx) c03a532e: 85 c0 test %eax,%eax c03a5330: 75 01 jne c03a5333 <__down_mutex+0x13> c03a5332: c3 ret that's how much it takes to acquire an RT lock, and i worked hard to get there. As long as the fastpath is kept this tight, feel free to do cleanups. But i really want to avoid having to write mutex_down/up in assembly for 24 architectures ... Ingo