From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750761AbVHXIvV (ORCPT ); Wed, 24 Aug 2005 04:51:21 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1750775AbVHXIvV (ORCPT ); Wed, 24 Aug 2005 04:51:21 -0400 Received: from gprs189-60.eurotel.cz ([160.218.189.60]:14227 "EHLO amd.ucw.cz") by vger.kernel.org with ESMTP id S1750761AbVHXIvU (ORCPT ); Wed, 24 Aug 2005 04:51:20 -0400 Date: Wed, 24 Aug 2005 10:50:54 +0200 From: Pavel Machek To: Shaohua Li Cc: lkml , akpm Subject: Re: [PATCH] Add MCE resume under ia32 Message-ID: <20050824085054.GA4310@elf.ucw.cz> References: <1124762500.3013.3.camel@linux-hp.sh.intel.com> <20050823103256.GB2795@elf.ucw.cz> <1124846001.3007.7.camel@linux-hp.sh.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1124846001.3007.7.camel@linux-hp.sh.intel.com> X-Warning: Reading this can be dangerous to your mental health. User-Agent: Mutt/1.5.9i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Hi! > > > diff -puN arch/i386/power/cpu.c~mcheck_resume arch/i386/power/cpu.c > > > --- linux-2.6.13-rc6/arch/i386/power/cpu.c~mcheck_resume 2005-08-23 09:32:13.054008584 +0800 > > > +++ linux-2.6.13-rc6-root/arch/i386/power/cpu.c 2005-08-23 09:41:54.992540480 +0800 > > > @@ -104,6 +104,8 @@ static void fix_processor_context(void) > > > > > > } > > > > > > +extern void mcheck_init(struct cpuinfo_x86 *c); > > > + > > > void __restore_processor_state(struct saved_context *ctxt) > > > { > > > /* > > > > > > this should go to some header file and most importantly > If you agree my other points, I'll do this. Ok. > > > @@ -138,6 +140,9 @@ void __restore_processor_state(struct sa > > > fix_processor_context(); > > > do_fpu_end(); > > > mtrr_ap_init(); > > > +#ifdef CONFIG_X86_MCE > > > + mcheck_init(&boot_cpu_data); > > > +#endif > > > } > > > > c) can't we register MCEs like some kind of system device so that this > > kind of hooks is not neccessary? > Like x86-64 does, right? In this way, we must register a device for each > cpu. But APs directly call mcheck_init in resume time (cpuhotplug > framework). Only BP requires to call the resume method, so I think > restore_processor_state calls it might be cleaner. Ahha, ok. Pavel -- if you have sharp zaurus hardware you don't need... you know my address