From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751154AbVHXQib (ORCPT ); Wed, 24 Aug 2005 12:38:31 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751148AbVHXQi3 (ORCPT ); Wed, 24 Aug 2005 12:38:29 -0400 Received: from parcelfarce.linux.theplanet.co.uk ([195.92.249.252]:7896 "EHLO parcelfarce.linux.theplanet.co.uk") by vger.kernel.org with ESMTP id S1751140AbVHXQi3 (ORCPT ); Wed, 24 Aug 2005 12:38:29 -0400 Date: Wed, 24 Aug 2005 17:41:33 +0100 From: Al Viro To: Roland Dreier Cc: Al Viro , torvalds@osdl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] (11/43) Kconfig fix (infiniband and PCI) Message-ID: <20050824164133.GL9322@parcelfarce.linux.theplanet.co.uk> References: <528xyr1f0c.fsf@cisco.com> <20050824163134.GK9322@parcelfarce.linux.theplanet.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20050824163134.GK9322@parcelfarce.linux.theplanet.co.uk> User-Agent: Mutt/1.4.1i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Aug 24, 2005 at 05:31:34PM +0100, Al Viro wrote: > On Wed, Aug 24, 2005 at 09:22:27AM -0700, Roland Dreier wrote: > > Al> infiniband uses PCI helpers all over the place (including the > > Al> core parts) and won't build without PCI. > > > > I don't think this is the right fix. The only PCI helpers used in > > code that is enabled with CONFIG_PCI=n are pci_unmap_addr_set() and > > pci_unmap_addr(). And they're only used because no one has added > > dma_unmap_addr_set() and dma_unmap_addr() -- the core code is properly > > using the general dma_xxx API wherever possible. > > > > There actually is non-PCI InfiniBand hardware coming, so we'll have to > > fix this properly at some point. > > I'm all for it and removing BROKEN from Kconfig when fixes happen is > obviously not a problem at all ;-) PS: note that it's not depends on PCI it's depends on PCI || BROKEN which a) documents that something is wrong b) leaves all setups usable now intact c) prevents broken setups from being picked. I certainly agree that proper fix is to switch to dma_... - no arguments here. BTW, another dubious thing is use of DECLARE_PCI_UNMAP_ADDR() in infiniband core - it's fine in PCI drivers (which is how it's used elsewhere), but not in generic data structures.