From: corbet@lwn.net (Jonathan Corbet)
To: Jean Delvare <khali@linux-fr.org>
Cc: Greg Kroah-Hartman <greg@kroah.com>,
torvalds@osdl.org, akpm@osdl.org, linux-kernel@vger.kernel.org,
lm-sensors@lm-sensors.org, Jonathan Corbet <corbet@lwn.net>,
Alexey Dobriyan <adobriyan@gmail.com>
Subject: Re: [PATCH] drivers/hwmon/*: kfree() correct pointers
Date: Thu, 25 Aug 2005 17:53:54 -0600 [thread overview]
Message-ID: <20050825235354.10376.qmail@lwn.net> (raw)
In-Reply-To: Your message of "Fri, 26 Aug 2005 00:02:31 +0200." <20050826000231.35b97af9.khali@linux-fr.org>
> Already fixed in Greg's i2c tree and -mm for quite some time now...
So it is. The comment says, however, that "the existing code works
somewhat by accident." In the case of the 9240 driver, however, the
existing code demonstrably does not work - it oopsed on me. The patch
in Greg's tree looks fine (it's a straightforward fix, after all); I'd
recommend that it be merged before 2.6.13.
jon
Jonathan Corbet
Executive editor, LWN.net
corbet@lwn.net
next prev parent reply other threads:[~2005-08-25 23:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-08-25 20:56 [PATCH] fix adm9240 oops Jonathan Corbet
2005-08-25 21:49 ` [PATCH] drivers/hwmon/*: kfree() correct pointers Alexey Dobriyan
2005-08-25 22:02 ` Jean Delvare
2005-08-25 23:53 ` Jonathan Corbet [this message]
2005-08-26 7:32 ` Jean Delvare
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050825235354.10376.qmail@lwn.net \
--to=corbet@lwn.net \
--cc=adobriyan@gmail.com \
--cc=akpm@osdl.org \
--cc=greg@kroah.com \
--cc=khali@linux-fr.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lm-sensors@lm-sensors.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®