From: Al Viro <viro@parcelfarce.linux.theplanet.co.uk>
To: blaisorblade@yahoo.it
Cc: torvalds@osdl.org, akpm@osdl.org, jdike@addtoit.com,
linux-kernel@vger.kernel.org,
user-mode-linux-devel@lists.sourceforge.net
Subject: Re: [patch 1/2] Fixup symlink function pointers for hppfs [for 2.6.13]
Date: Fri, 26 Aug 2005 20:03:39 +0100 [thread overview]
Message-ID: <20050826190339.GA9322@parcelfarce.linux.theplanet.co.uk> (raw)
In-Reply-To: <20050826145749.03BFE24D661@zion.home.lan>
On Fri, Aug 26, 2005 at 04:57:44PM +0200, blaisorblade@yahoo.it wrote:
>
> From: Paolo 'Blaisorblade' Giarrusso <blaisorblade@yahoo.it>
>
> Update hppfs for the symlink functions prototype change.
> Should be trivial, but please verify it's correct.
>
> Yes, I know the code I leave there is still _bogus_, see next patch for this.
Assuming that the next patch was "hppfs: fix symlink error path",
you've still left BS in there -
> proc_file = dentry_open(dget(proc_dentry), NULL, O_RDONLY);
is obviously wrong; at the very least you need vfsmount in there.
next prev parent reply other threads:[~2005-08-26 19:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-08-26 14:57 blaisorblade
2005-08-26 19:03 ` Al Viro [this message]
2005-08-26 20:04 ` Blaisorblade
2005-08-26 21:48 ` Al Viro
2005-09-18 12:00 ` [uml-devel] " Blaisorblade
2005-09-21 3:23 ` Al Viro
2005-09-21 3:40 ` Al Viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050826190339.GA9322@parcelfarce.linux.theplanet.co.uk \
--to=viro@parcelfarce.linux.theplanet.co.uk \
--cc=akpm@osdl.org \
--cc=blaisorblade@yahoo.it \
--cc=jdike@addtoit.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
--cc=user-mode-linux-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome