From: Ingo Oeser <ioe-lkml@rameria.de>
To: Venkatesh Pallipadi <venkatesh.pallipadi@intel.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@osdl.org>, Len Brown <len.brown@intel.com>
Subject: Re: [PATCH] acpi: Handle cpu_index greater than 256 properly in processor_core.c
Date: Sat, 27 Aug 2005 14:22:40 +0200 [thread overview]
Message-ID: <200508271422.46473.ioe-lkml@rameria.de> (raw)
In-Reply-To: <20050826170701.A27226@unix-os.sc.intel.com>
[-- Attachment #1: Type: text/plain, Size: 634 bytes --]
Hi Venkatesh,
On Saturday 27 August 2005 02:07, Venkatesh Pallipadi wrote:
> Fix convert_acpiid_to_cpu function to handle cpu_index greater than 256. This
> patch also prevents a warning in IA64 cross-compile of this file
> (drivers/acpi/processor_core.c:517: warning: comparison is always false due
> to limited range of data type).
Why don't you just change the datatype to "unsigned int" and
the return failure value to NR_CPUS?
That reduces the code changes and leaves the code quite clear.
It should also reduce compiled code size by some bytes, but I'm not
sure about that one.
Regards
Ingo Oeser
[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]
next prev parent reply other threads:[~2005-08-27 12:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-08-27 0:07 Venkatesh Pallipadi
2005-08-27 12:22 ` Ingo Oeser [this message]
2005-08-29 21:59 Pallipadi, Venkatesh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200508271422.46473.ioe-lkml@rameria.de \
--to=ioe-lkml@rameria.de \
--cc=akpm@osdl.org \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=venkatesh.pallipadi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®