From: "'Christoph Hellwig'" <hch@lst.de>
To: "Bagalkote, Sreenivas" <sreenib@lsil.com>
Cc: "'linux-kernel@vger.kernel.org'" <linux-kernel@vger.kernel.org>,
"'linux-scsi@vger.kernel.org'" <linux-scsi@vger.kernel.org>,
"'Christoph Hellwig'" <hch@lst.de>,
"'James Bottomley'" <James.Bottomley@SteelEye.com>,
Andrew Morton <akpm@osdl.org>
Subject: Re: [PATCH scsi-misc 2/2] megaraid_sas: LSI Logic MegaRAID SAS RAID D river
Date: Mon, 29 Aug 2005 19:05:50 +0200 [thread overview]
Message-ID: <20050829170550.GA21128@lst.de> (raw)
In-Reply-To: <0E3FA95632D6D047BA649F95DAB60E57060CD100@exa-atlanta>
Looks pretty good to me. Small issues I've identified:
- what do you need the hba_count attribute for? This should be
implementable in userspace pretty easily by iterating of all
devices of the scsi_host class that are attached to the driver
- the ->queuecommand cleanup patch I sent you a awhile ago doesn't
seem to be applied
- there's quite a lot of slightly odd formating, it would be nice
if you could run the code through scripts/Lindent.
If you could sent out an unmangled patch (even as attachment or on
LSI's ftp side) I'd like to take another, closer look.
next parent reply other threads:[~2005-08-29 17:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <0E3FA95632D6D047BA649F95DAB60E57060CD100@exa-atlanta>
2005-08-29 17:05 ` 'Christoph Hellwig' [this message]
2005-08-25 21:40 Bagalkote, Sreenivas
-- strict thread matches above, loose matches on Subject: below --
2005-06-04 5:26 Bagalkote, Sreenivas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050829170550.GA21128@lst.de \
--to=hch@lst.de \
--cc=James.Bottomley@SteelEye.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=sreenib@lsil.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®