From: Dominik Brodowski <linux@dominikbrodowski.net>
To: Venkatesh Pallipadi <venkatesh.pallipadi@intel.com>
Cc: Andrew Morton <akpm@osdl.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
Len Brown <len.brown@intel.com>
Subject: Re: [PATCH] acpi-cpufreq: Remove P-state read after a P-state write in normal path
Date: Thu, 1 Sep 2005 10:48:31 +0200 [thread overview]
Message-ID: <20050901084831.GA6285@isilmar.linta.de> (raw)
In-Reply-To: <20050829110357.A14724@unix-os.sc.intel.com>
Hi,
On Mon, Aug 29, 2005 at 11:03:57AM -0700, Venkatesh Pallipadi wrote:
> Yes. ACPI spec says transitions can fail. But, it doesn't fail often in
> practise. And even if it fails, I think, we should handle it without this
> read os STATUS register.
How can we handle it, if we do not even know that it failed? How should the
user recognize something is broken?
> The speedstep-centrino driver, which does similar
> thing as acpi-cpufreq, does not do this status check after control MSR write.
> We can skip the read of STATUS in cpi-cpufreq in a similar way. No?
Well, regarding speedstep-centrino, it is news to me that the MSR write can
fail... if it can fail, we should check for it.
> And reading the STATUS in a loop should go away. I don't see that it being
> mentioned in ACPI spec. The 1mS loop seems totally redundant.
It looks to me as somebody had experienced that the transition only
succeeded after waiting for some time.
But well, as you do know the ACPI spec better than I do, I'll accept your
evaluation that this patch won't cause any trouble.
Dominik
next prev parent reply other threads:[~2005-09-01 8:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-08-27 0:10 Venkatesh Pallipadi
2005-08-28 18:09 ` Dominik Brodowski
2005-08-29 18:03 ` Venkatesh Pallipadi
2005-09-01 8:48 ` Dominik Brodowski [this message]
2005-08-27 2:27 Brown, Len
2005-09-01 18:44 Brown, Len
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050901084831.GA6285@isilmar.linta.de \
--to=linux@dominikbrodowski.net \
--cc=akpm@osdl.org \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=venkatesh.pallipadi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome