From: Tom Rini <trini@kernel.crashing.org>
To: mingo@elte.hu
Cc: dwalker@mvista.com, linux-kernel@vger.kernel.org
Subject: [PATCH] RT: Invert some TRACE_BUG_ON_LOCKED tests
Date: Fri, 2 Sep 2005 13:08:56 -0700 [thread overview]
Message-ID: <20050902200856.GY3966@smtp.west.cox.net> (raw)
In-Reply-To: <1125691250.2709.2.camel@c-67-188-6-232.hsd1.ca.comcast.net>
With 2.6.13-rt4 I had to do the following in order to get my paired down
config booting on my x86 whitebox (defconfig works fine, after I enable
enet/8250_console/nfsroot). Daniel Walker helped me trace this down.
Signed-off-by: Tom Rini <trini@kernel.crashing.org>
--- linux-2.6.13/kernel/rt.c 2005-09-02 12:39:02.000000000 -0700
+++ linux-2.6.13/kernel/rt.c 2005-09-02 12:24:04.000000000 -0700
@@ -736,8 +736,8 @@
if (old_owner == new_owner)
return;
- TRACE_BUG_ON_LOCKED(!spin_is_locked(&old_owner->task->pi_lock));
- TRACE_BUG_ON_LOCKED(!spin_is_locked(&new_owner->task->pi_lock));
+ TRACE_BUG_ON_LOCKED(spin_is_locked(&old_owner->task->pi_lock));
+ TRACE_BUG_ON_LOCKED(spin_is_locked(&new_owner->task->pi_lock));
plist_for_each_safe(curr1, next1, &old_owner->task->pi_waiters) {
w = plist_entry(curr1, struct rt_mutex_waiter, pi_list);
if (w->lock == lock) {
@@ -770,8 +770,8 @@
return;
}
- TRACE_BUG_ON_LOCKED(!spin_is_locked(&lock->wait_lock));
- TRACE_BUG_ON_LOCKED(!spin_is_locked(&p->pi_lock));
+ TRACE_BUG_ON_LOCKED(spin_is_locked(&lock->wait_lock));
+ TRACE_BUG_ON_LOCKED(spin_is_locked(&p->pi_lock));
#ifdef CONFIG_RT_DEADLOCK_DETECT
pi_prio++;
if (p->policy != SCHED_NORMAL && prio > normal_prio(p)) {
@@ -967,8 +967,8 @@
/*
* Add SCHED_NORMAL tasks to the end of the waitqueue (FIFO):
*/
- TRACE_BUG_ON_LOCKED(!spin_is_locked(&task->pi_lock));
- TRACE_BUG_ON_LOCKED(!spin_is_locked(&lock->wait_lock));
+ TRACE_BUG_ON_LOCKED(spin_is_locked(&task->pi_lock));
+ TRACE_BUG_ON_LOCKED(spin_is_locked(&lock->wait_lock));
#if !ALL_TASKS_PI
if (!rt_task(task)) {
plist_add(&waiter->list, &lock->wait_list);
@@ -1070,7 +1070,7 @@
struct rt_mutex_waiter *waiter = NULL;
struct thread_info *new_owner;
- TRACE_BUG_ON_LOCKED(!spin_is_locked(&lock->wait_lock));
+ TRACE_BUG_ON_LOCKED(spin_is_locked(&lock->wait_lock));
/*
* Get the highest prio one:
*
--
Tom Rini
http://gate.crashing.org/~trini/
next prev parent reply other threads:[~2005-09-02 20:09 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-09-02 20:00 [PATCH] RT: set LPPTEST default to off Daniel Walker
2005-09-02 20:08 ` Tom Rini [this message]
2005-09-02 22:40 ` [PATCH] RT: Invert some TRACE_BUG_ON_LOCKED tests Steven Rostedt
2005-09-02 22:53 ` Steven Rostedt
2005-09-06 15:16 ` Tom Rini
2005-09-12 13:43 ` Ingo Molnar
2005-09-12 13:47 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050902200856.GY3966@smtp.west.cox.net \
--to=trini@kernel.crashing.org \
--cc=dwalker@mvista.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®