From: Jiri Slaby <jirislaby@gmail.com>
To: Greg KH <gregkh@suse.de>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-pci@atrey.karlin.mff.cuni.cz, alsa-devel@alsa-project.org,
perex@suse.cz
Subject: [PATCH 5/6] include, sound: pci_find_device remove (s/pci/cs46xx/cs46xx_lib.c)
Date: Fri, 2 Sep 2005 23:44:55 +0200 [thread overview]
Message-ID: <200509022144.j82LitTO031347@wscnet.wsc.cz> (raw)
In-Reply-To: <200509022122.j82LMMwV030426@wscnet.wsc.cz>
Generated in 2.6.13-mm1 kernel version.
Signed-off-by: Jiri Slaby <xslaby@fi.muni.cz>
include/sound/cs46xx.h | 1 -
sound/pci/cs46xx/cs46xx_lib.c | 13 +++++++++----
2 files changed, 9 insertions(+), 5 deletions(-)
diff --git a/include/sound/cs46xx.h b/include/sound/cs46xx.h
--- a/include/sound/cs46xx.h
+++ b/include/sound/cs46xx.h
@@ -1715,7 +1715,6 @@ struct _snd_cs46xx {
void (*active_ctrl)(cs46xx_t *, int);
void (*mixer_init)(cs46xx_t *);
- struct pci_dev *acpi_dev;
int acpi_port;
snd_kcontrol_t *eapd_switch; /* for amplifier hack */
int accept_valid; /* accept mmap valid (for OSS) */
diff --git a/sound/pci/cs46xx/cs46xx_lib.c b/sound/pci/cs46xx/cs46xx_lib.c
--- a/sound/pci/cs46xx/cs46xx_lib.c
+++ b/sound/pci/cs46xx/cs46xx_lib.c
@@ -3548,7 +3548,7 @@ static void clkrun_hack(cs46xx_t *chip,
{
u16 control, nval;
- if (chip->acpi_dev == NULL)
+ if (!chip->acpi_port)
return;
chip->amplifier += change;
@@ -3571,15 +3571,20 @@ static void clkrun_hack(cs46xx_t *chip,
*/
static void clkrun_init(cs46xx_t *chip)
{
+ struct pci_dev *pdev;
u8 pp;
- chip->acpi_dev = pci_find_device(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_82371AB_3, NULL);
- if (chip->acpi_dev == NULL)
+ chip->acpi_port = 0;
+
+ pdev = pci_get_device(PCI_VENDOR_ID_INTEL,
+ PCI_DEVICE_ID_INTEL_82371AB_3, NULL);
+ if (pdev == NULL)
return; /* Not a thinkpad thats for sure */
/* Find the control port */
- pci_read_config_byte(chip->acpi_dev, 0x41, &pp);
+ pci_read_config_byte(pdev, 0x41, &pp);
chip->acpi_port = pp << 8;
+ pci_dev_put(pdev);
}
next prev parent reply other threads:[~2005-09-02 21:45 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-09-02 21:22 [PATCH 0/6] include, sound: pci_find_device remove Jiri Slaby
2005-09-02 21:44 ` [PATCH 6/6] include, sound: pci_find_device remove (s/pci/via82xx.c) Jiri Slaby
2005-09-07 13:29 ` [Alsa-devel] " Takashi Iwai
2005-09-02 21:44 ` [PATCH 3/6] include, sound: pci_find_device remove (s/pci/ali5451/ali5451.c) Jiri Slaby
2005-09-02 21:44 ` [PATCH 2/6] include, sound: pci_find_device remove (s/core/memalloc.c) Jiri Slaby
2005-09-02 21:44 ` Jiri Slaby [this message]
2005-09-02 21:44 ` [PATCH 4/6] include, sound: pci_find_device remove (s/pci/au88x0/au88x0.c) Jiri Slaby
2005-09-02 21:45 ` [PATCH 1/6] include, sound: pci_find_device remove (include/asm-i386/ide.h) Jiri Slaby
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200509022144.j82LitTO031347@wscnet.wsc.cz \
--to=jirislaby@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@atrey.karlin.mff.cuni.cz \
--cc=perex@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®