From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750894AbVICMBv (ORCPT ); Sat, 3 Sep 2005 08:01:51 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751024AbVICMBu (ORCPT ); Sat, 3 Sep 2005 08:01:50 -0400 Received: from mailout.stusta.mhn.de ([141.84.69.5]:53265 "HELO mailout.stusta.mhn.de") by vger.kernel.org with SMTP id S1750888AbVICMBu (ORCPT ); Sat, 3 Sep 2005 08:01:50 -0400 Date: Sat, 3 Sep 2005 14:01:34 +0200 From: Adrian Bunk To: David Vrabel Cc: James Simmons , "Antonino A. Daplas" , Andrew Morton , linux-kernel@vger.kernel.org, linux-fbdev-devel@lists.sourceforge.net Subject: [-mm patch] FB_GEODE should depend on PCI Message-ID: <20050903120134.GL3657@stusta.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.10i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Due to fbdev-geode-updates.patch, building with CONFIG_PCI=n results in the following error: <-- snip --> ... CC [M] drivers/video/geode/gx1fb_core.o drivers/video/geode/gx1fb_core.c: In function 'gx1fb_map_video_memory': drivers/video/geode/gx1fb_core.c:218: warning: implicit declaration of function 'pci_request_region' drivers/video/geode/gx1fb_core.c: In function 'gx1fb_probe': drivers/video/geode/gx1fb_core.c:372: warning: implicit declaration of function 'pci_release_region' ... if [ -r System.map -a -x /sbin/depmod ]; then /sbin/depmod -ae -F System.map 2.6.13-mm1; fi WARNING: /lib/modules/2.6.13-mm1/kernel/drivers/video/geode/gx1fb.ko needs unknown symbol pci_release_region <-- snip --> Since the driver doesn't seem to be working without pci_request_region() this patch adds the required dependency on PCI. The dependency is placed at FB_GEODE since there's (at least currently) no reason to show this option if no driver depending on it is available without PCI. Additionally, it removes two superfluous "default n". Signed-off-by: Adrian Bunk --- linux-2.6.13-mm1-full/drivers/video/geode/Kconfig.old 2005-09-03 13:55:41.000000000 +0200 +++ linux-2.6.13-mm1-full/drivers/video/geode/Kconfig 2005-09-03 13:56:17.000000000 +0200 @@ -3,15 +3,13 @@ # config FB_GEODE bool "AMD Geode family framebuffer support (EXPERIMENTAL)" - default n - depends on FB && EXPERIMENTAL && X86 + depends on FB && PCI && EXPERIMENTAL && X86 ---help--- Say 'Y' here to allow you to select framebuffer drivers for the AMD Geode family of processors. config FB_GEODE_GX1 tristate "AMD Geode GX1 framebuffer support (EXPERIMENTAL)" - default n depends on FB_GEODE && EXPERIMENTAL select FB_CFB_FILLRECT select FB_CFB_COPYAREA