Re: [PATCH 03/11] memory hotplug prep: __section_nr helper

[Denis Vlasenko <vda@ilport.com.ua>]

On Friday 02 September 2005 23:56, Dave Hansen wrote:
> 
> A little helper that we use in the hotplug code.
> 
> Signed-off-by: Dave Hansen <haveblue@us.ibm.com>
> ---
> 
>  memhotplug-dave/include/linux/mmzone.h |   25 +++++++++++++++++++++++++
>  1 files changed, 25 insertions(+)
> 
> diff -puN include/linux/mmzone.h~C3-__section_nr include/linux/mmzone.h
> --- memhotplug/include/linux/mmzone.h~C3-__section_nr	2005-08-18 14:59:45.000000000 -0700
> +++ memhotplug-dave/include/linux/mmzone.h	2005-08-18 14:59:45.000000000 -0700
> @@ -511,6 +511,31 @@ static inline struct mem_section *__nr_t
>  }
>  
>  /*
> + * Although written for the SPARSEMEM_EXTREME case, this happens
> + * to also work for the flat array case becase
> + * NR_SECTION_ROOTS==NR_MEM_SECTIONS.
> + */
> +static inline int __section_nr(struct mem_section* ms)
> +{
> +	unsigned long root_nr;
> +	struct mem_section* root;
> +
> +	for (root_nr = 0;
> +	     root_nr < NR_MEM_SECTIONS;
> +	     root_nr += SECTIONS_PER_ROOT) {
> +		root = __nr_to_section(root_nr);
> +
> +		if (!root)
> +			continue;
> +
> +		if ((ms >= root) && (ms < (root + SECTIONS_PER_ROOT)))
> +		     break;
> +	}
> +
> +	return (root_nr * SECTIONS_PER_ROOT) + (ms - root);
> +}
> +
> +/*

isn't it too much for the inlining?
--
vda