From: Francois Romieu <romieu@fr.zoreil.com>
To: Giampaolo Tomassoni <g.tomassoni@libero.it>
Cc: linux-kernel@vger.kernel.org, linux-atm-general@lists.sourceforge.net
Subject: Re: [Linux-ATM-General] [ATMSAR] Request for review - update #1
Date: Sun, 4 Sep 2005 14:00:47 +0200 [thread overview]
Message-ID: <20050904120047.GA6556@electric-eye.fr.zoreil.com> (raw)
In-Reply-To: <NBBBIHMOBLOHKCGIMJMDGEHPEKAA.g.tomassoni@libero.it>
Giampaolo Tomassoni <g.tomassoni@libero.it> :
[...]
> However, I'm still hearing for your comments about the usefulness of an
> ATMSAR layer.
Afaik all but one pci ADSL modems are out of tree drivers and include various
level of proprietary code. If Duncan is not interested in changing its code,
the usefulness remains to be proven.
The codingstyle is broken. Please read again Documentation/CodingStyle,
remove the redundant typedef and the silly comments ("Reserve header space",
Encode packet into cells", ...).
- &page[strlen(page)] in atmProcRead sucks.
- "return" is not a function.
- consider 'goto' to handle the errors instead of deep nesting
- +const atmsar_aalops_t opsAALR = {
+ ATM_AAL0,
+ "raw",
-> use .foo = baz instead.
drivers/net/*c may give some hint.
--
Ueimor
next prev parent reply other threads:[~2005-09-04 12:03 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-09-04 11:05 Giampaolo Tomassoni
2005-09-04 12:00 ` Francois Romieu [this message]
2005-09-04 13:13 ` R: [Linux-ATM-General] " Giampaolo Tomassoni
2005-09-04 15:32 ` Francois Romieu
2005-09-04 18:44 ` R: " Giampaolo Tomassoni
2005-09-04 19:11 ` matthieu castet
2005-09-04 19:33 ` R: " Giampaolo Tomassoni
2005-09-04 19:42 ` Giampaolo Tomassoni
2005-09-05 6:05 ` Zoran Stojsavljevic
2005-09-05 6:21 ` R: " Giampaolo Tomassoni
2005-09-04 16:20 ` Alistair John Strachan
2005-09-04 16:41 ` Grzegorz Kulewski
2005-09-04 16:54 ` Alistair John Strachan
2005-09-04 17:22 ` Grzegorz Kulewski
2005-09-05 15:04 ` Duncan Sands
2005-09-04 18:36 ` R: " Giampaolo Tomassoni
2005-09-04 18:51 ` Alistair John Strachan
2005-09-05 9:36 ` David Woodhouse
2005-09-05 13:52 ` Alistair John Strachan
2005-09-05 13:56 ` David Woodhouse
2005-09-05 14:18 ` Alistair John Strachan
2005-09-05 14:32 ` David Woodhouse
2005-09-05 14:46 ` Duncan Sands
2005-09-04 16:55 ` Jiri Slaby
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050904120047.GA6556@electric-eye.fr.zoreil.com \
--to=romieu@fr.zoreil.com \
--cc=g.tomassoni@libero.it \
--cc=linux-atm-general@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®