From: Ingo Oeser <ioe-lkml@rameria.de>
To: Adrian Bunk <bunk@stusta.de>
Cc: Matt Mackall <mpm@selenic.com>, linux-kernel@vger.kernel.org
Subject: Re: [2.6 patch] lib/sort.c: small cleanups
Date: Sun, 4 Sep 2005 13:35:37 +0200 [thread overview]
Message-ID: <200509041335.38532.ioe-lkml@rameria.de> (raw)
In-Reply-To: <20050903132531.GO3657@stusta.de>
On Saturday 03 September 2005 15:25, Adrian Bunk wrote:
> This patch contains the following small cleanups:
> - make two needlessly global functions static
> - every file should #include the header files containing the prototypes
> of it's global functions
While this is a nice cleanup, does anybody remember,
why the inner loops are duplicated in the source?
If there are no arguments for it, I would like to consolidate them
to a function or a define, if they share to much state.
Or is the duplicate just considered cleaner?
Regards
Ingo Oeser
prev parent reply other threads:[~2005-09-04 11:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-09-03 13:25 Adrian Bunk
2005-09-04 11:35 ` Ingo Oeser [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200509041335.38532.ioe-lkml@rameria.de \
--to=ioe-lkml@rameria.de \
--cc=bunk@stusta.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mpm@selenic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®