From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751038AbVIFWRw (ORCPT ); Tue, 6 Sep 2005 18:17:52 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751039AbVIFWRw (ORCPT ); Tue, 6 Sep 2005 18:17:52 -0400 Received: from smtp.osdl.org ([65.172.181.4]:47593 "EHLO smtp.osdl.org") by vger.kernel.org with ESMTP id S1751036AbVIFWRv (ORCPT ); Tue, 6 Sep 2005 18:17:51 -0400 Date: Tue, 6 Sep 2005 15:15:46 -0700 From: Andrew Morton To: "John W. Linville" Cc: hch@infradead.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, jgarzik@pobox.com Subject: Re: [patch 2.6.13 2/2] 3c59x: add option for using memory-mapped PCI I/O resources Message-Id: <20050906151546.4d5ed4db.akpm@osdl.org> In-Reply-To: <20050906220922.GA26003@tuxdriver.com> References: <20050906204147.GC20145@tuxdriver.com> <20050906204400.GD20145@tuxdriver.com> <20050906205429.GA19319@infradead.org> <20050906140414.40b65253.akpm@osdl.org> <20050906220922.GA26003@tuxdriver.com> X-Mailer: Sylpheed version 1.0.4 (GTK+ 1.2.10; i386-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org "John W. Linville" wrote: > > I fully intend to have have a flag in the private data set based on > the PCI ID when I accumulate some data on which devices support this > and which don't. So far I've only got a short list... Do you think > such a flag should be based on which ones work, or which ones break? The ones which are known to work. Bear in mind that this is an old, messy and relatively stable driver which handles a huge number of different NICs. Caution is the rule here.