From: Robin Holt <holt@sgi.com>
To: Paul Jackson <pj@sgi.com>, KUROSAWA Takahiro <kurosawa@valinux.co.jp>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/5][BUG] SUBCPUSETS: fix for cpusets minor problem
Date: Thu, 8 Sep 2005 06:17:31 -0500 [thread overview]
Message-ID: <20050908111731.GA19987@lnx-holt.americas.sgi.com> (raw)
In-Reply-To: <20050908054053.35DAD70031@sv1.valinux.co.jp>
On Thu, Sep 08, 2005 at 02:40:53PM +0900, KUROSAWA Takahiro wrote:
> This patch fixes minor problem that the CPUSETS have when files
> in the cpuset filesystem are read after lseek()-ed beyond the EOF.
>
> Signed-off-by: KUROSAWA Takahiro <kurosawa@valinux.co.jp>
>
> --- from-0001/kernel/cpuset.c
> +++ to-work/kernel/cpuset.c 2005-09-05 20:26:18.075772762 +0900
> @@ -984,6 +984,10 @@ static ssize_t cpuset_common_file_read(s
> *s++ = '\n';
> *s = '\0';
>
> + /* Do nothing if *ppos is at the eof or beyond the eof. */
> + if (s - page <= *ppos)
> + return 0;
> +
> start = page + *ppos;
> n = s - start;
> retval = n - copy_to_user(buf, start, min(n, nbytes));
Paul, I think this should go in regardless of the other subcpuset
changes being proposed. What do you think?
Robin
next prev parent reply other threads:[~2005-09-08 11:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-09-08 5:40 KUROSAWA Takahiro
2005-09-08 11:17 ` Robin Holt [this message]
2005-09-08 11:25 ` Robin Holt
2005-09-08 11:58 ` Paul Jackson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050908111731.GA19987@lnx-holt.americas.sgi.com \
--to=holt@sgi.com \
--cc=kurosawa@valinux.co.jp \
--cc=linux-kernel@vger.kernel.org \
--cc=pj@sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®