Re: [-mm patch 2/5] SharpSL: Add cxx00 support to the Corgi LCD driver

[Russell King <rmk+lkml@arm.linux.org.uk>]

On Tue, Sep 06, 2005 at 12:53:48PM +0100, Richard Purdie wrote:
> +/*
> + * Corgi/Spitz Touchscreen to LCD interface
> + */
> +unsigned long inline corgi_get_hsync_len(void) 
> +{
> +	if (machine_is_corgi() || machine_is_shepherd() || machine_is_husky()) {
> +#ifdef CONFIG_PXA_SHARP_C7xx
> +		return w100fb_get_hsynclen(&corgifb_device.dev);
> +#endif
> +	} else if (machine_is_spitz() || machine_is_akita() || machine_is_borzoi()) {
> +#ifdef CONFIG_PXA_SHARP_Cxx00
> +		return pxafb_get_hsync_time(&pxafb_device.dev);
> +#endif

This means you have to force these drivers to be built (since this file
will always be built for sharp stuff.)  This doesn't seem like a good
solution.

> +#define SyncHS(x)   while((GPLR(x) & GPIO_bit(x)) == 0); while((GPLR(x) & GPIO_bit(x)) != 0);

That's particularly gruesome - firstly, two statements inside a macro.
Secondly, no barrier() or cpu_relax() in there (as the kernel janitors
like to see.)  It won't make any difference to the generated code, but
makes other folk happier.

-- 
Russell King
 Linux kernel    2.6 ARM Linux   - http://www.arm.linux.org.uk/
 maintainer of:  2.6 Serial core