From: Tom Rini <trini@kernel.crashing.org>
To: Jan Beulich <JBeulich@novell.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] i386 CFI annotations
Date: Thu, 8 Sep 2005 08:46:45 -0700 [thread overview]
Message-ID: <20050908154645.GN3966@smtp.west.cox.net> (raw)
In-Reply-To: <432070850200007800024465@emea1-mh.id2.novell.com>
On Thu, Sep 08, 2005 at 05:10:29PM +0200, Jan Beulich wrote:
> As a foundation for reliable stack unwinding, this adds CFI unwind
> annotations to many low-level i386 routines, plus a config option
> (available to all architectures) to enable them as well as the
> compiler
> producing similar information for all C sources.
>
> Signed-off-by: Jan Beulich <jbeulich@novell.com>
x86_64 has proper CFI annotations on things, and just depends on
DEBUG_INFO. Perhaps that would be a slightly easier path to use for
pushing this along?
> + CFI_ADJUST_CFA_OFFSET 4;\
> + /*CFI_REL_OFFSET es, 0;*/\
> pushl %ds; \
> + CFI_ADJUST_CFA_OFFSET 4;\
> + /*CFI_REL_OFFSET ds, 0;*/\
Adding new commented out code never wins new friends. :)
> diff -Npru 2.6.13/include/asm-i386/dwarf2.h
[snip]
> +#ifdef CONFIG_UNWIND_INFO
[snip]
> +#else
[snip]
> +#define CFI_STARTPROC ignore
Why not just empty defines?
--
Tom Rini
http://gate.crashing.org/~trini/
next prev parent reply other threads:[~2005-09-08 15:46 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-09-08 15:10 Jan Beulich
2005-09-08 15:46 ` Tom Rini [this message]
[not found] ` <43207BA30200007800024502@emea1-mh.id2.novell.com>
[not found] ` <20050908161334.GP3966@smtp.west.cox.net>
2005-09-09 6:51 ` Jan Beulich
2005-09-10 5:58 ` Richard Henderson
2005-09-12 7:04 ` Jan Beulich
2005-09-12 7:49 ` Richard Henderson
2005-09-12 13:09 ` Daniel Jacobowitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050908154645.GN3966@smtp.west.cox.net \
--to=trini@kernel.crashing.org \
--cc=JBeulich@novell.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®