mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Chuck Ebbert <76306.1226@compuserve.com>
To: linux-kernel <linux-kernel@vger.kernel.org>
Cc: Andi Kleen <ak@suse.de>, Linus Torvalds <torvalds@osdl.org>,
	Len Brown <len.brown@intel.com>
Subject: [patch 2.6.13] x86: check host bridge when applying vendor quirks
Date: Thu, 8 Sep 2005 22:33:50 -0400	[thread overview]
Message-ID: <200509082236_MC3-1-A99D-81DD@compuserve.com> (raw)

I was looking at the i386 ACPI early quirk code and x86_64 equivalent
and it seems to me it should be checking the host bridge vendor, not
the one for various PCI bridges.  Nvidia might release some kind of
PCI card with an embedded bridge that would break this code, for
example.  I made this patch but I can't test it:

Signed-off-by: Chuck Ebbert <76306.1226@compuserve.com>

 arch/i386/kernel/acpi/earlyquirk.c |    2 +-
 arch/x86_64/kernel/io_apic.c       |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

--- 2.6.13a.orig/arch/i386/kernel/acpi/earlyquirk.c
+++ 2.6.13a/arch/i386/kernel/acpi/earlyquirk.c
@@ -36,7 +36,7 @@ void __init check_acpi_pci(void) 
 				if (class == 0xffffffff)
 					break; 
 
-				if ((class >> 16) != PCI_CLASS_BRIDGE_PCI)
+				if ((class >> 16) != PCI_CLASS_BRIDGE_HOST)
 					continue; 
 				
 				vendor = read_pci_config(num, slot, func, 
--- 2.6.13a.orig/arch/x86_64/kernel/io_apic.c
+++ 2.6.13a/arch/x86_64/kernel/io_apic.c
@@ -242,7 +242,7 @@ void __init check_ioapic(void) 
 				if (class == 0xffffffff)
 					break; 
 
-		       		if ((class >> 16) != PCI_CLASS_BRIDGE_PCI)
+		       		if ((class >> 16) != PCI_CLASS_BRIDGE_HOST)
 					continue; 
 
 				vendor = read_pci_config(num, slot, func, 
__
Chuck

             reply	other threads:[~2005-09-09  2:36 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-09-09  2:33 Chuck Ebbert [this message]
2005-09-09  2:47 ` Andi Kleen
2005-09-09  5:19   ` Piter PUNK
2005-09-09  6:07     ` Andi Kleen
2005-09-09  4:44 Chuck Ebbert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200509082236_MC3-1-A99D-81DD@compuserve.com \
    --to=76306.1226@compuserve.com \
    --cc=ak@suse.de \
    --cc=len.brown@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®