From: Stephen Hemminger <shemminger@osdl.org>
To: Josip Loncaric <josip@lanl.gov>
Cc: linux-kernel@vger.kernel.org, linux-net@vger.kernel.org
Subject: Re: PROBLEM: sk98lin misbehaves with D-Link DGE-530T which doesn't have readable VPD
Date: Fri, 9 Sep 2005 11:05:50 -0700 [thread overview]
Message-ID: <20050909110550.3fb82d36@localhost.localdomain> (raw)
In-Reply-To: <4321CB39.3080206@lanl.gov>
On Fri, 09 Sep 2005 11:49:45 -0600
Josip Loncaric <josip@lanl.gov> wrote:
> Driver sk98lin makes repeated attempts to read VPD even after the first
> VpdInit() fails. This is wrong.
>
> Lots of people seem to be getting repeated "Vpd: Cannot read VPD keys"
> errors. When nifd is active, this can happen every second, causing
> kernel stalls that disrupt time-critical operations (e.g. DVD use).
The sk98lin driver is wrapped around VPD for it's silly proprietary
network management interface.
> Inexpensive cards like D-Link DGE-530T may lack a readable VPD, so there
> is no point in trying to access this missing feature and causing brief
> system stalls (see
> https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=136158).
>
> Can sk98lin be enhanced to give up on VPD after the first VpdInit()
> fails? The NIC appears to operate stably even without a readable VPD.
>
> I haven't tested the experimental driver skge, but the same comment may
> apply. Obviously it makes no sense to repeatedly look for VPD keys when
> the VPD is missing or incorrect.
Skge doesn't use VPD for anything, it works fine on my D-Link card.
The same data is available for applications that have a need
(like linux-diag lsvpd) via the standard pci interface in sysfs.
Now that skge is in 2.6.13, perhaps the proper thing to do is to take
DGE-530T out of the PCI table for sk98lin?
next prev parent reply other threads:[~2005-09-09 18:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <42EE9721.5000501@lanl.gov>
2005-09-09 17:49 ` Josip Loncaric
2005-09-09 18:05 ` Stephen Hemminger [this message]
2005-09-09 18:22 ` Josip Loncaric
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050909110550.3fb82d36@localhost.localdomain \
--to=shemminger@osdl.org \
--cc=josip@lanl.gov \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-net@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®