From: Chuck Ebbert <76306.1226@compuserve.com>
To: Hugh Dickins <hugh@veritas.com>
Cc: Andi Kleen <ak@suse.de>, Jan Beulich <JBeulich@novell.com>,
linux-kernel <linux-kernel@vger.kernel.org>,
discuss@x86-64.org
Subject: Re: [discuss] [PATCH] allow CONFIG_FRAME_POINTER for x86-64
Date: Fri, 9 Sep 2005 13:50:35 -0400 [thread overview]
Message-ID: <200509091351_MC3-1-A9A7-F01A@compuserve.com> (raw)
In-Reply-To: <Pine.LNX.4.61.0509091208350.6247@goblin.wat.veritas.com>
On Fri, 9 Sep 2005 at 12:14:38 +0100 (BST), Hugh Dickins wrote:
> On Fri, 9 Sep 2005, Andi Kleen wrote:
> >
> > It won't give more accurate backtraces, not even on i386 because show_stack
> > doesn't have any code to follow frame pointers.
>
> Ah, right.
What's this for, then? (arch/i386/kernel/traps.c line 116)
static inline unsigned long print_context_stack(struct thread_info *tinfo,
unsigned long *stack, unsigned long ebp)
{
unsigned long addr;
#ifdef CONFIG_FRAME_POINTER
while (valid_stack_ptr(tinfo, (void *)ebp)) {
addr = *(unsigned long *)(ebp + 4);
printk(" [<%08lx>] ", addr);
print_symbol("%s", addr);
printk("\n");
ebp = *(unsigned long *)ebp;
}
#else
I get nice clean stack traces on i386 with frame pointers enabled and
the kernel is smaller as well.
__
Chuck
Subliminal URL: www.sluggy.com/daily.php?date=050905
next reply other threads:[~2005-09-09 17:52 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-09-09 17:50 Chuck Ebbert [this message]
2005-09-10 0:16 ` Andi Kleen
-- strict thread matches above, loose matches on Subject: below --
2005-09-08 16:04 Jan Beulich
2005-09-09 8:54 ` [discuss] " Andi Kleen
2005-09-09 9:16 ` Jan Beulich
2005-09-09 9:23 ` Andi Kleen
2005-09-09 9:40 ` Jan Beulich
2005-09-09 10:45 ` Hugh Dickins
2005-09-09 10:58 ` Andi Kleen
2005-09-09 11:14 ` Hugh Dickins
2005-09-09 11:21 ` Andi Kleen
2005-09-09 11:31 ` Hugh Dickins
2005-09-09 11:42 ` Andi Kleen
2005-09-09 12:00 ` Hugh Dickins
2005-09-09 17:19 ` Alexander Nyberg
2005-09-10 5:13 ` Andrew Morton
2005-09-10 6:12 ` Andi Kleen
2005-09-09 11:07 ` Philippe Elie
2005-09-09 11:19 ` Andi Kleen
2005-09-09 12:41 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200509091351_MC3-1-A9A7-F01A@compuserve.com \
--to=76306.1226@compuserve.com \
--cc=JBeulich@novell.com \
--cc=ak@suse.de \
--cc=discuss@x86-64.org \
--cc=hugh@veritas.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®