From: Andrew Morton <akpm@osdl.org>
To: Nishanth Aravamudan <nacc@us.ibm.com>
Cc: dwmw2@infradead.org, bunk@stusta.de, johnstul@us.ibm.com,
drepper@redhat.com, Franz.Fischer@goyellow.de,
linux-kernel@vger.kernel.org
Subject: Re: [UPDATE PATCH][Bug 5132] fix sys_poll() large timeout handling
Date: Fri, 9 Sep 2005 19:36:21 -0700 [thread overview]
Message-ID: <20050909193621.5d578583.akpm@osdl.org> (raw)
In-Reply-To: <20050910022330.GD24225@us.ibm.com>
Nishanth Aravamudan <nacc@us.ibm.com> wrote:
>
> + /*
> + * We compare HZ with 1000 to work out which side of the
> + * expression needs conversion. Because we want to avoid
> + * converting any value to a numerically higher value, which
> + * could overflow.
> + */
> +#if HZ > 1000
> + overflow = timeout_msecs >= jiffies_to_msecs(MAX_SCHEDULE_TIMEOUT);
> +#else
> + overflow = msecs_to_jiffies(timeout_msecs) >= MAX_SCHEDULE_TIMEOUT;
> +#endif
> +
> + /*
> + * If we would overflow in the conversion or a negative timeout
> + * is requested, sleep indefinitely.
> + */
> + if (overflow || timeout_msecs < 0)
> + timeout_jiffies = MAX_SCHEDULE_TIMEOUT;
Do we need to test (timeout_msecs < 0) here? If we make timeout_msecs
unsigned long then I think `overflow' will always be correct.
next prev parent reply other threads:[~2005-09-10 2:40 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-08-31 20:01 [PATCH][Bug " Nishanth Aravamudan
2005-09-06 21:25 ` Nishanth Aravamudan
2005-09-10 0:35 ` [UPDATE PATCH][Bug " Nishanth Aravamudan
2005-09-10 1:16 ` Andrew Morton
2005-09-10 2:23 ` Nishanth Aravamudan
2005-09-10 2:36 ` Andrew Morton [this message]
2005-09-10 2:55 ` Nishanth Aravamudan
2005-09-12 14:30 ` Peter Staubach
2005-09-12 15:05 ` Nishanth Aravamudan
2005-09-12 15:19 ` Peter Staubach
2005-09-12 16:06 ` Nishanth Aravamudan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050909193621.5d578583.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=Franz.Fischer@goyellow.de \
--cc=bunk@stusta.de \
--cc=drepper@redhat.com \
--cc=dwmw2@infradead.org \
--cc=johnstul@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nacc@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®