From: Sam Ravnborg <sam@ravnborg.org>
To: linux-kernel@vger.kernel.org, Linus Torvalds <torvalds@osdl.org>
Subject: [PATCH 3/7] kbuild: adjust .version updating
Date: Sat, 10 Sep 2005 22:35:32 +0200 [thread overview]
Message-ID: <20050910203531.GC29334@mars.ravnborg.org> (raw)
In-Reply-To: <20050910200347.GA3762@mars.ravnborg.org>
In order to maintain a more correct build number, updates to the
version
number should only be commited after a successful link of vmlinux, not
before (so that errors in the link process don't lead to pointless
increments).
Signed-off-by: Jan Beulich <jbeulich@novell.com>
Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
---
Makefile | 10 ++++++++--
1 files changed, 8 insertions(+), 2 deletions(-)
4e25d8bb9550fb5912165196fe8502cdb831a336
diff --git a/Makefile b/Makefile
--- a/Makefile
+++ b/Makefile
@@ -641,8 +641,13 @@ quiet_cmd_vmlinux__ ?= LD $@
# Generate new vmlinux version
quiet_cmd_vmlinux_version = GEN .version
cmd_vmlinux_version = set -e; \
- . $(srctree)/scripts/mkversion > .tmp_version; \
- mv -f .tmp_version .version; \
+ if [ ! -r .version ]; then \
+ rm -f .version; \
+ echo 1 >.version; \
+ else \
+ mv .version .old_version; \
+ expr 0$$(cat .old_version) + 1 >.version; \
+ fi; \
$(MAKE) $(build)=init
# Generate System.map
@@ -756,6 +761,7 @@ endif # ifdef CONFIG_KALLSYMS
# vmlinux image - including updated kernel symbols
vmlinux: $(vmlinux-lds) $(vmlinux-init) $(vmlinux-main) $(kallsyms.o) FORCE
$(call if_changed_rule,vmlinux__)
+ $(Q)rm -f .old_version
# The actual objects are generated when descending,
# make sure no implicit rule kicks in
next prev parent reply other threads:[~2005-09-10 20:33 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-09-10 20:03 [GIT PATCHES] final kbuild update before fix-only period Sam Ravnborg
2005-09-10 20:34 ` [PATCH 1/7] kbuild: add kernelrelease to 'make help' Sam Ravnborg
2005-09-10 20:34 ` [PATCH 2/7] kbuild: CF=<arguments> passes arguments to sparse Sam Ravnborg
2005-09-10 20:35 ` Sam Ravnborg [this message]
2005-09-10 20:36 ` [PATCH 4/7] kbuild: fix split-include dependency Sam Ravnborg
2005-09-10 20:36 ` [PATCH 5/7] kbuild: ignore all debugging info sections in scripts/reference_discarded.pl Sam Ravnborg
2005-09-10 20:37 ` [PATCH 6/7] kbuild: add objectify Sam Ravnborg
2005-09-10 20:38 ` [PATCH 7/7] kbuild: fix generic asm-offsets.h support Sam Ravnborg
2005-09-11 12:26 ` [GIT PATCHES] final kbuild update before fix-only period Denis Vlasenko
2005-09-11 14:00 ` Sam Ravnborg
2005-09-12 7:19 ` Denis Vlasenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050910203531.GC29334@mars.ravnborg.org \
--to=sam@ravnborg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®