mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "David S. Miller" <davem@davemloft.net>
To: torvalds@osdl.org
Cc: akropel1@rochester.rr.com, nkiesel@tbdnetworks.com,
	linux-kernel@vger.kernel.org
Subject: Re: 2.6.13.1 locks machine after some time, 2.6.12.5 work fine
Date: Tue, 13 Sep 2005 13:22:13 -0700 (PDT)	[thread overview]
Message-ID: <20050913.132213.01982680.davem@davemloft.net> (raw)
In-Reply-To: <Pine.LNX.4.58.0509130850550.3351@g5.osdl.org>

From: Linus Torvalds <torvalds@osdl.org>
Date: Tue, 13 Sep 2005 08:55:31 -0700 (PDT)

> >         /* Reset expansion ROM address decode enable */
> >         pci_read_config_word(ha->pdev, PCI_ROM_ADDRESS, &w);
> >         w &= ~PCI_ROM_ADDRESS_ENABLE;
> >         pci_write_config_word(ha->pdev, PCI_ROM_ADDRESS, w);
 ...
> So the above probably works fine, especially since it's just disabling the 
> ROM (ie we don't end up caring at all about the upper bits even if they 
> did get the wrong value). But it's definitely bad practice, and there are 
> probably cards (for which that driver is irrelevant, of course ;) where 
> doing something like the above might not work at all.

I think for consistency the above driver case should still be fixed,
however.  This way when people try to audit the tree for
PCI_ROM_ADDRESS config space accesses, they won't come across this
same instance again and again.

  reply	other threads:[~2005-09-13 20:22 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-09-12 23:59 Norbert Kiesel
2005-09-13  3:00 ` Linus Torvalds
2005-09-13  3:38   ` Norbert Kiesel
2005-09-13 14:25     ` Linus Torvalds
2005-09-13 14:57       ` Linus Torvalds
2005-09-13 16:02         ` Adam Kropelin
2005-09-13 15:55           ` Linus Torvalds
2005-09-13 20:22             ` David S. Miller [this message]
2005-09-13 22:25               ` Adam Kropelin
2005-09-13 23:11                 ` [PATCH] ibmphp: Use dword accessors for PCI_ROM_ADDRESS Adam Kropelin
2005-09-13 23:15                 ` [PATCH] pciehp: " Adam Kropelin
2005-09-13 23:17                 ` [PATCH] shpchp: " Adam Kropelin
2005-09-13 23:20                 ` [PATCH] qla2xxx: " Adam Kropelin
2005-09-13 16:27       ` 2.6.13.1 locks machine after some time, 2.6.12.5 work fine Norbert Kiesel
2005-09-13 17:09       ` Norbert Kiesel
2005-09-13 17:23         ` Linus Torvalds
2005-09-13 21:23           ` Norbert Kiesel
2005-09-13 22:24             ` Chris Wright

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050913.132213.01982680.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=akropel1@rochester.rr.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nkiesel@tbdnetworks.com \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®