From: Sonny Rao <sonny@burdell.org>
To: Jiri Slaby <jirislaby@gmail.com>
Cc: akpm@osdl.org, linux-kernel@vger.kernel.org,
linuxppc64-dev@ozlabs.org, brking@us.ibm.com,
Alan Cox <alan@lxorguk.ukuu.org.uk>
Subject: Re: 2.6.13-mm3
Date: Tue, 13 Sep 2005 01:58:32 -0400 [thread overview]
Message-ID: <20050913055832.GA28971@kevlar.burdell.org> (raw)
In-Reply-To: <4326229B.6040002@gmail.com>
On Tue, Sep 13, 2005 at 02:51:39AM +0200, Jiri Slaby wrote:
> Sonny Rao napsal(a):
>
> >On Mon, Sep 12, 2005 at 05:49:45PM -0400, Sonny Rao wrote:
> >
> >
> >>--- linux-2.6.13-mm3/drivers/char/hvc_console.c~orig 2005-09-12
> >>16:37:14.434077464 -0500
> >>+++ linux-2.6.13-mm3/drivers/char/hvc_console.c 2005-09-12
> >>16:37:25.466998360 -0500
> >>@@ -597,7 +597,7 @@ static int hvc_poll(struct hvc_struct *h
> >>
> >> /* Read data if any */
> >> for (;;) {
> >>- count = tty_buffer_request_room(tty, N_INBUF);
> >>+ int count = tty_buffer_request_room(tty, N_INBUF);
> >>
> >> /* If flip is full, just reschedule a later read */
> >> if (count == 0) {
> >>@@ -633,7 +633,7 @@ static int hvc_poll(struct hvc_struct *h
> >> tty_insert_flip_char(tty, buf[i], 0);
> >> }
> >>
> >>- if (tty->flip.count)
> >>+ if (tty->buf.tail->used)
> >>
> >>
> Is there any better way to gather this info? I think, that this was my
> bad idea. Some encapsulation needed.
>
I agree, this is ugly as hell. I don't know if the tty stuff was
ever supposed to be used this way. Given the revamp, and if this usage is
legal, perhaps the addition of a generic wrapper to the API is
warranted.
Sonny
next prev parent reply other threads:[~2005-09-13 6:02 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-09-12 9:43 2.6.13-mm3 Andrew Morton
2005-09-12 11:47 ` 2.6.13-mm3 Michal Piotrowski
2005-09-12 11:48 ` 2.6.13-mm3 [OOPS] vfs, page_owner, full reproductively, badness in vsnprintf Michal Piotrowski
2005-09-12 17:54 ` Alexander Nyberg
2005-09-12 18:48 ` Ingo Oeser
2005-09-12 21:13 ` Michal Piotrowski
2005-09-12 22:44 ` Andrew Morton
2005-09-12 22:56 ` Michal Piotrowski
2005-09-12 23:16 ` Andrew Morton
2005-09-12 13:15 ` 2.6.13-mm3 Reuben Farrelly
2005-09-12 14:17 ` 2.6.13-mm3 BUG in ntfs or slab Jiri Slaby
2005-09-12 14:21 ` Jiri Slaby
2005-09-12 14:45 ` Anton Altaparmakov
2005-09-12 14:17 ` 2.6.13-mm3 Andrew Walrond
2005-09-12 14:26 ` 2.6.13-mm3 Nick Piggin
2005-09-12 14:54 ` 2.6.13-mm3 Sonny Rao
2005-09-12 19:56 ` 2.6.13-mm3 Andrew Morton
2005-09-12 20:09 ` 2.6.13-mm3 Sonny Rao
2005-09-12 20:55 ` 2.6.13-mm3 Andrew Morton
2005-09-12 21:03 ` 2.6.13-mm3 Danny ter Haar
2005-09-12 22:06 ` 2.6.13-mm3 Sonny Rao
2005-09-12 22:47 ` 2.6.13-mm3 Martin J. Bligh
2005-09-13 5:19 ` 2.6.13-mm3 Danny ter Haar
2005-09-13 6:35 ` 2.6.13-mm3 Sonny Rao
2005-09-13 5:14 ` 2.6.13-mm3 Danny ter Haar
2005-09-13 7:02 ` 2.6.13-mm3 Sonny Rao
2005-09-13 14:31 ` 2.6.13-mm3 Martin J. Bligh
2005-09-13 18:32 ` 2.6.13-mm3 Sonny Rao
2005-09-13 18:46 ` 2.6.13-mm3 Sonny Rao
2005-09-12 15:19 ` 2.6.13-mm3 Paolo Ciarrocchi
2005-09-12 20:13 ` 2.6.13-mm3 Nish Aravamudan
2005-09-12 21:04 ` 2.6.13-mm3 Paolo Ciarrocchi
2005-09-12 21:07 ` 2.6.13-mm3 Nish Aravamudan
2005-09-12 22:50 ` 2.6.13-mm3 Martin J. Bligh
2005-09-12 19:40 ` 2.6.13-mm3 Sonny Rao
[not found] ` <200509122106.j8CL6WPk006092@wscnet.wsc.cz>
2005-09-12 21:49 ` 2.6.13-mm3 Sonny Rao
2005-09-12 22:10 ` 2.6.13-mm3 Sonny Rao
2005-09-13 0:51 ` 2.6.13-mm3 Jiri Slaby
2005-09-13 5:58 ` Sonny Rao [this message]
[not found] ` <20050912222437.GA13124@sergelap.austin.ibm.com>
2005-09-12 23:10 ` ibmvscsi badness (Re: 2.6.13-mm3) Andrew Morton
2005-09-13 1:38 ` Anton Blanchard
2005-09-13 8:56 ` serue
2005-09-13 15:09 ` [Patch] ibmvscsi compatibility fix Dave C Boutcher
2005-09-13 15:18 ` James Bottomley
2005-09-13 18:10 ` Serge E. Hallyn
2005-09-13 19:16 ` Serge E. Hallyn
2005-09-13 4:04 ` ibmvscsi badness (Re: 2.6.13-mm3) Anton Blanchard
2005-09-13 5:10 ` Dave C Boutcher
2005-09-18 0:38 ` Benjamin Herrenschmidt
2005-09-13 0:02 ` drivers/usb/class/bluetty.c does NOT build Lion Vollnhals
2005-09-13 0:10 ` Andrew Morton
2005-09-13 0:34 ` [PATCH] usb: bluetty fix old tty buffer using Jiri Slaby
2005-09-15 18:58 ` 2.6.13-mm3 (general protection fault) Dominik Karall
2005-09-15 19:34 ` Andrew Morton
2005-09-15 19:36 ` Andrew Morton
2006-01-14 17:39 ` 2.6.13-mm3 Matthias Urlichs
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050913055832.GA28971@kevlar.burdell.org \
--to=sonny@burdell.org \
--cc=akpm@osdl.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=brking@us.ibm.com \
--cc=jirislaby@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc64-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®