From: Andi Kleen <ak@suse.de>
To: Linus Torvalds <torvalds@osdl.org>
Cc: Daniel Jacobowitz <dan@debian.org>,
"Markus F.X.J. Oberhumer" <markus@oberhumer.com>,
linux-kernel@vger.kernel.org, Andi Kleen <ak@suse.de>
Subject: Re: [PATCH] i386: fix stack alignment for signal handlers
Date: Wed, 14 Sep 2005 17:44:25 +0200 [thread overview]
Message-ID: <20050914154425.GM11338@wotan.suse.de> (raw)
In-Reply-To: <Pine.LNX.4.58.0509140753260.26803@g5.osdl.org>
On Wed, Sep 14, 2005 at 07:55:53AM -0700, Linus Torvalds wrote:
>
>
> On Wed, 14 Sep 2005, Daniel Jacobowitz wrote:
> >
> > The comment for the relevant bits of the GCC configuration says it won't
> > assume this for x86, but I believe that comment is out of date. I think
> > it'll assume 16-byte alignment on entrance to non-main() functions.
>
> Well, that's kind of the point. We _do_ have the stack aligned on
> entrance, but it looks like gcc wants it _non-aligned_. It seems to want
> it offset by the "return address push" - ie it seems to expect that it was
> aligned before the "call", but entry into the next function will thus
> _never_ be aligned.
>
> So the kernel actually seems to have it _too_ aligned right now.
Yes it's wrong. I would recommend to apply Markus' patch for i386
and x86-64.
-Andi
next prev parent reply other threads:[~2005-09-14 15:44 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-09-13 20:55 Markus F.X.J. Oberhumer
2005-09-13 22:53 ` Linus Torvalds
2005-09-13 23:30 ` Markus F.X.J. Oberhumer
2005-09-13 23:52 ` Linus Torvalds
2005-09-14 1:39 ` Markus F.X.J. Oberhumer
2005-09-14 4:54 ` Andi Kleen
2005-09-14 14:22 ` Daniel Jacobowitz
2005-09-14 14:55 ` Linus Torvalds
2005-09-14 15:44 ` Andi Kleen [this message]
2005-10-09 16:54 ` Markus F.X.J. Oberhumer
2005-10-09 16:57 ` Andi Kleen
2005-10-09 17:06 ` Markus F.X.J. Oberhumer
2005-10-11 0:23 ` Markus F.X.J. Oberhumer
2005-09-14 20:11 ` J.A. Magallon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050914154425.GM11338@wotan.suse.de \
--to=ak@suse.de \
--cc=dan@debian.org \
--cc=linux-kernel@vger.kernel.org \
--cc=markus@oberhumer.com \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®