mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: dtor_core@ameritech.net
Cc: Robert Love <rml@novell.com>, Mr Morton <akpm@osdl.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [patch] hdaps driver update.
Date: Wed, 14 Sep 2005 10:39:18 -0700	[thread overview]
Message-ID: <20050914173918.GB24058@kroah.com> (raw)
In-Reply-To: <d120d5000509141028252d060c@mail.gmail.com>

On Wed, Sep 14, 2005 at 12:28:15PM -0500, Dmitry Torokhov wrote:
> On 9/14/05, Greg KH <greg@kroah.com> wrote:
> > 
> > No, if you have that .owner field in your driver, you get a symlink in
> > sysfs that points from your driver to the module that controls it.  You
> > just removed that symlink, which is not what I think you wanted to have
> > happen :(
> > 
> 
> Hmm, i have a concern WRT to that link - it is only present if driver
> is registered from a code compiled as a module. If driver is built-in
> THIS_MODULE is NULL and symlink will not be created. Hovewer
> /sys/modules/<module> is created regardless of whether module is a
> module or built-in. So the behavior is inconsistent and it looks like
> a replacement is needed.

Ok, care to come up with a suggestion of how to fix this?

thanks,

greg k-h

  reply	other threads:[~2005-09-14 17:39 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-09-14 15:57 Robert Love
2005-09-14 16:05 ` Greg KH
2005-09-14 16:09   ` Robert Love
2005-09-14 16:16     ` Greg KH
2005-09-14 16:31       ` Robert Love
2005-09-14 17:14         ` Dmitry Torokhov
2005-09-14 17:55           ` Robert Love
2005-09-14 17:38         ` Greg KH
2005-09-14 17:28       ` Dmitry Torokhov
2005-09-14 17:39         ` Greg KH [this message]
2005-09-14 18:19 ` [patch] hdaps driver update, updated Robert Love

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050914173918.GB24058@kroah.com \
    --to=greg@kroah.com \
    --cc=akpm@osdl.org \
    --cc=dtor_core@ameritech.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rml@novell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®