From: Andrew Morton <akpm@osdl.org>
To: "Machida, Hiroyuki" <machida@sm.sony.co.jp>
Cc: hirofumi@mail.parknet.co.jp, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2][FAT] miss-sync issues on sync mount (miss-sync on write)
Date: Wed, 14 Sep 2005 19:48:20 -0700 [thread overview]
Message-ID: <20050914194820.5bbddcb3.akpm@osdl.org> (raw)
In-Reply-To: <43288964.7020307@sm.sony.co.jp>
"Machida, Hiroyuki" <machida@sm.sony.co.jp> wrote:
>
> This patch fixes miss-sync issue on write() system call.
> This updates inode attrs flags, mtime and ctime on every
> comit_write call, due to locking.
This all seems wrong.
Why does fatfs have file_operations.write pointing at do_sync_write()
rather than generic_file_write()?
Why does fatfs have a custom .aio_write() rather than using
generic_file_aio_write()?
If fatfs can use all the standard library functions, all this inode
dirtying and O_SYNC/-o sync handling shoud just work.
next prev parent reply other threads:[~2005-09-15 2:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-09-14 20:34 Machida, Hiroyuki
2005-09-15 2:48 ` Andrew Morton [this message]
2005-09-15 12:43 ` OGAWA Hirofumi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050914194820.5bbddcb3.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=hirofumi@mail.parknet.co.jp \
--cc=linux-kernel@vger.kernel.org \
--cc=machida@sm.sony.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®