mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Dmitry Torokhov <dtor_core@ameritech.net>
To: linux-kernel@vger.kernel.org
Cc: Andrew Morton <akpm@osdl.org>, Greg KH <gregkh@suse.de>,
	Kay Sievers <kay.sievers@vrfy.org>,
	Vojtech Pavlik <vojtech@suse.cz>, Hannes Reinecke <hare@suse.de>
Subject: [patch 09/28] Input: convert net/bluetooth to dynamic input_dev allocation
Date: Thu, 15 Sep 2005 02:01:40 -0500	[thread overview]
Message-ID: <20050915070302.931769000.dtor_core@ameritech.net> (raw)
In-Reply-To: <20050915070131.813650000.dtor_core@ameritech.net>

[-- Attachment #1: input-dynalloc-bluetooth.patch --]
[-- Type: text/plain, Size: 1698 bytes --]

Input: convert net/bluetooth to dynamic input_dev allocation

This is required for input_dev sysfs integration

Signed-off-by: Dmitry Torokhov <dtor@mail.ru>
---

 net/bluetooth/hidp/core.c |   13 ++++++++-----
 1 files changed, 8 insertions(+), 5 deletions(-)

Index: work/net/bluetooth/hidp/core.c
===================================================================
--- work.orig/net/bluetooth/hidp/core.c
+++ work/net/bluetooth/hidp/core.c
@@ -520,7 +520,7 @@ static int hidp_session(void *arg)
 
 	if (session->input) {
 		input_unregister_device(session->input);
-		kfree(session->input);
+		session->input = NULL;
 	}
 
 	up_write(&hidp_session_sem);
@@ -536,6 +536,8 @@ static inline void hidp_setup_input(stru
 
 	input->private = session;
 
+	input->name = "Bluetooth HID Boot Protocol Device";
+
 	input->id.bustype = BUS_BLUETOOTH;
 	input->id.vendor  = req->vendor;
 	input->id.product = req->product;
@@ -582,16 +584,15 @@ int hidp_add_connection(struct hidp_conn
 		return -ENOTUNIQ;
 
 	session = kmalloc(sizeof(struct hidp_session), GFP_KERNEL);
-	if (!session) 
+	if (!session)
 		return -ENOMEM;
 	memset(session, 0, sizeof(struct hidp_session));
 
-	session->input = kmalloc(sizeof(struct input_dev), GFP_KERNEL);
+	session->input = input_allocate_device();
 	if (!session->input) {
 		kfree(session);
 		return -ENOMEM;
 	}
-	memset(session->input, 0, sizeof(struct input_dev));
 
 	down_write(&hidp_session_sem);
 
@@ -651,8 +652,10 @@ unlink:
 
 	__hidp_unlink_session(session);
 
-	if (session->input)
+	if (session->input) {
 		input_unregister_device(session->input);
+		session->input = NULL; /* don't try to free it here */
+	}
 
 failed:
 	up_write(&hidp_session_sem);


  parent reply	other threads:[~2005-09-15  7:08 UTC|newest]

Thread overview: 54+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-09-15  7:01 [patch 00/28] RFC/RFT: Input - sysfs integration Dmitry Torokhov
2005-09-15  7:01 ` [patch 01/28] I2O: remove class interface Dmitry Torokhov
2005-09-27  0:03   ` Greg KH
2005-09-27  8:39     ` Markus Lidel
2005-09-15  7:01 ` [patch 02/28] I2O: remove i2o_device_class Dmitry Torokhov
2005-09-27  0:28   ` Greg KH
2005-09-15  7:01 ` [patch 03/28] Driver core: allow nesting classes Dmitry Torokhov
2005-09-15  7:01 ` [patch 04/28] Driver core: make parent class define subsystem Dmitry Torokhov
2005-09-15  7:01 ` [patch 05/28] Driver core: pass interface to class intreface methods Dmitry Torokhov
2005-09-15  7:01 ` [patch 06/28] Driver core: send hotplug event before adding class interfaces Dmitry Torokhov
2005-09-15  7:01 ` [patch 07/28] Input: kill devfs references Dmitry Torokhov
2005-09-15  7:01 ` [patch 08/28] Input: prepare to sysfs integration Dmitry Torokhov
2005-10-05 22:03   ` Greg KH
2005-10-05 22:17     ` Dmitry Torokhov
2005-10-05 22:55       ` Greg KH
2005-10-06 17:46         ` Dmitry Torokhov
2005-10-06 23:05           ` Vojtech Pavlik
2005-10-07  3:58             ` Dmitry Torokhov
2005-10-07  6:41               ` Al Viro
2005-10-07  6:49                 ` Dmitry Torokhov
2005-09-15  7:01 ` Dmitry Torokhov [this message]
2005-09-15  7:54   ` [patch 09/28] Input: convert net/bluetooth to dynamic input_dev allocation Marcel Holtmann
2005-09-15 14:22     ` Dmitry Torokhov
2005-09-15 14:41       ` Marcel Holtmann
2005-09-15 19:07         ` Vojtech Pavlik
2005-09-15 19:22           ` Dmitry Torokhov
2005-09-15 19:31             ` Greg KH
2005-09-15 19:52               ` Dmitry Torokhov
2005-09-15 20:25             ` Vojtech Pavlik
2005-09-15 20:55               ` Dmitry Torokhov
2005-09-15 21:16                 ` Vojtech Pavlik
2005-09-15  7:01 ` [patch 10/28] Input: convert drivers/macintosh " Dmitry Torokhov
2005-09-15  7:01 ` [patch 11/28] Input: convert konicawc " Dmitry Torokhov
2005-09-15  7:01 ` [patch 12/28] Input: convert onetouch " Dmitry Torokhov
2005-09-15  7:01 ` [patch 13/28] drivers/input/mouse: convert " Dmitry Torokhov
2005-09-15  7:01 ` [patch 14/28] drivers/input/keyboard: " Dmitry Torokhov
2005-09-15  7:01 ` [patch 15/28] drivers/input/touchscreen: " Dmitry Torokhov
2005-09-15  7:01 ` [patch 17/28] Input: convert ucb1x00-ts " Dmitry Torokhov
2005-09-15  7:01 ` [patch 18/28] Input: convert sound/ppc/beep " Dmitry Torokhov
2005-09-15  7:01 ` [patch 19/28] Input: convert sonypi " Dmitry Torokhov
2005-09-15  7:01 ` [patch 20/28] Input: convert driver/input/misc " Dmitry Torokhov
2005-09-15  7:01 ` [patch 22/28] drivers/media: convert " Dmitry Torokhov
2005-09-15  7:01 ` [patch 23/28] Input: show sysfs path in /proc/bus/input/devices Dmitry Torokhov
2005-09-15  7:01 ` [patch 24/28] Input: export input_dev data via sysfs attributes Dmitry Torokhov
2005-09-15  7:01 ` [patch 25/28] input core: implement class hierachy Dmitry Torokhov
2005-09-15  7:01 ` [patch 26/28] input core: remove custom-made hotplug handler Dmitry Torokhov
2005-09-15  7:01 ` [patch 27/28] Input: convert input handlers to class interfaces Dmitry Torokhov
2005-09-15  7:01 ` [patch 28/28] Input: convert to seq_file Dmitry Torokhov
2005-09-15  7:59 ` [patch 00/28] RFC/RFT: Input - sysfs integration Marcel Holtmann
2005-09-15 14:27   ` Dmitry Torokhov
     [not found] ` <20050915070304.070090000.dtor_core@ameritech.net>
2005-09-16  3:53   ` [patch 16/28] drivers/usb/input: convert to dynamic input_dev allocation Andrew Morton
2005-09-16  3:59     ` Dmitry Torokhov
2005-09-16  4:18       ` Andrew Morton
2005-09-16  4:30         ` Dmitry Torokhov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050915070302.931769000.dtor_core@ameritech.net \
    --to=dtor_core@ameritech.net \
    --cc=akpm@osdl.org \
    --cc=gregkh@suse.de \
    --cc=hare@suse.de \
    --cc=kay.sievers@vrfy.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=vojtech@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome