mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Serge E. Hallyn" <serue@us.ibm.com>
To: Andrew Morton <akpm@osdl.org>
Cc: linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: 2.6.14-rc1-mm1
Date: Fri, 16 Sep 2005 12:49:39 -0500	[thread overview]
Message-ID: <20050916174939.GA3916@IBM-BWN8ZTBWAO1> (raw)
In-Reply-To: <20050916022319.12bf53f3.akpm@osdl.org>

I still need the following two patches against icom.c (the first
from Alan cox) applied.  With these, 2.6.14-rc1-mm1 compiles and
boots on my power5 machine.

thanks,
-serge

Index: linux-2.6.13-rc7/drivers/serial/icom.c
===================================================================
--- linux-2.6.13-rc7.orig/drivers/serial/icom.c	2005-09-16 15:22:57.000000000 -0500
+++ linux-2.6.13-rc7/drivers/serial/icom.c	2005-09-16 15:27:15.000000000 -0500
@@ -736,6 +736,7 @@ static void recv_interrupt(u16 port_int_
 
 	status = cpu_to_le16(icom_port->statStg->rcv[rcv_buff].flags);
 	while (status & SA_FL_RCV_DONE) {
+		int first = -1;
 
 		trace(icom_port, "FID_STATUS", status);
 		count = cpu_to_le16(icom_port->statStg->rcv[rcv_buff].leLength);
@@ -750,15 +751,17 @@ static void recv_interrupt(u16 port_int_
 			icom_port->recv_buf_pci;
 
 		/* Block copy all but the last byte as this may have status */
-		if(count > 0)
+		if(count > 0) {
+			first = icon->recv_buf[offset];
 			tty_insert_flip_string(tty, icon_port->recv_buf + offset, count - 1);
+		}
 
 		icount = &icom_port->uart_port.icount;
 		icount->rx += count;
 
 		/* Break detect logic */
 		if ((status & SA_FLAGS_FRAME_ERROR)
-		    && (tty->flip.char_buf_ptr[0] == 0x00)) {
+		    && first == 0) {
 			status &= ~SA_FLAGS_FRAME_ERROR;
 			status |= SA_FLAGS_BREAK_DET;
 			trace(icom_port, "BREAK_DET", 0);


Signed-off-by: Serge Hallyn <serue@us.ibm.com>

Index: linux-2.6.13-rc7/drivers/serial/icom.c
===================================================================
--- linux-2.6.13-rc7.orig/drivers/serial/icom.c	2005-09-16 15:27:15.000000000 -0500
+++ linux-2.6.13-rc7/drivers/serial/icom.c	2005-09-16 15:28:26.000000000 -0500
@@ -752,8 +752,8 @@ static void recv_interrupt(u16 port_int_
 
 		/* Block copy all but the last byte as this may have status */
 		if(count > 0) {
-			first = icon->recv_buf[offset];
-			tty_insert_flip_string(tty, icon_port->recv_buf + offset, count - 1);
+			first = icom_port->recv_buf[offset];
+			tty_insert_flip_string(tty, icom_port->recv_buf + offset, count - 1);
 		}
 
 		icount = &icom_port->uart_port.icount;
@@ -804,7 +804,7 @@ static void recv_interrupt(u16 port_int_
 
 		}
 
-		tty_insert_flip_char(tty, icon_port->recv_buf + offset + count - 1, flag);
+		tty_insert_flip_char(tty, *(icom_port->recv_buf + offset + count - 1), flag);
 
 		if (status & SA_FLAGS_OVERRUN)
 			/*


  parent reply	other threads:[~2005-09-16 15:40 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-09-16  9:23 2.6.14-rc1-mm1 Andrew Morton
2005-09-16  9:45 ` 2.6.14-rc1-mm1 Pekka Enberg
2005-09-16 10:17 ` 2.6.14-rc1-mm1 Anton Blanchard
2005-09-16 20:55   ` 2.6.14-rc1-mm1 Sonny Rao
2005-09-19 20:01     ` 2.6.14-rc1-mm1 Sonny Rao
2005-09-16 12:20 ` [PATCH] drivers/base: a little speedup and cleanup Jiri Slaby
2005-09-16 15:48   ` Dmitry Torokhov
2005-09-16 17:49 ` Serge E. Hallyn [this message]
2005-09-16 18:41 ` 2.6.14-rc1-mm1 Dominik Karall
2005-09-16 19:46   ` 2.6.14-rc1-mm1 Jiri Slaby
2005-09-16 19:59     ` 2.6.14-rc1-mm1 Kay Sievers
2005-09-16 20:04       ` 2.6.14-rc1-mm1 Jiri Slaby
2005-09-16 21:30       ` 2.6.14-rc1-mm1 Greg KH
2005-09-16 23:53         ` 2.6.14-rc1-mm1 Valdis.Kletnieks
2005-09-17  0:10           ` 2.6.14-rc1-mm1 Greg KH
2005-09-17  1:18             ` 2.6.14-rc1-mm1 Dr.Dre
2005-09-17  1:29               ` 2.6.14-rc1-mm1 Kay Sievers
2005-09-17  0:15           ` 2.6.14-rc1-mm1 Andrew Morton
2005-09-17  4:09             ` 2.6.14-rc1-mm1 Valdis.Kletnieks
2005-09-17  1:22 ` 2.6.14-rc1-mm1 Avuton Olrich
2005-09-17  4:41   ` 2.6.14-rc1-mm1 Andrew Morton
2005-09-17 10:10     ` 2.6.14-rc1-mm1 Neil Brown
2005-09-17  1:51 ` 2.6.14-rc1-mm1 Martin J. Bligh
2005-09-17  4:22   ` 2.6.14-rc1-mm1 Martin J. Bligh
2005-09-17  4:25 ` [PATCH] mips: Fixed build error Yoichi Yuasa
2005-09-17  4:33   ` Andrew Morton
2005-09-17  5:27     ` Yoichi Yuasa
2005-09-20 22:42 ` one more oops on sensor modules removal J.A. Magallon
2005-09-21  5:56   ` Andrew Morton
2005-09-21  8:52     ` Grant Coady
2005-10-01 11:39     ` Jean Delvare

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050916174939.GA3916@IBM-BWN8ZTBWAO1 \
    --to=serue@us.ibm.com \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®