From: Karsten Keil <kkeil@suse.de>
To: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Fix ST 5481 USB driver
Date: Mon, 19 Sep 2005 16:29:50 +0200 [thread overview]
Message-ID: <20050919142950.GA13757@pingi3.kke.suse.de> (raw)
In-Reply-To: <20050919142121.GA2959@pingi3.kke.suse.de>
On Mon, Sep 19, 2005 at 04:21:21PM +0200, Karsten Keil wrote:
> Hi Greg,
>
> On Sat, Sep 17, 2005 at 03:26:40PM -0700, Greg KH wrote:
> > On Sat, Sep 17, 2005 at 11:52:42PM +0200, Karsten Keil wrote:
> > > // Cancel all USB transfers on this B channel
> > > + b_out->urb[0]->transfer_flags |= URB_ASYNC_UNLINK;
> > > usb_unlink_urb(b_out->urb[0]);
> > > + b_out->urb[1]->transfer_flags |= URB_ASYNC_UNLINK;
> >
> > URB_ASYNC_UNLINK is now gone in 2.6.14-rc1, so this change will break
> > the build :(
> >
>
> OK, what would be the correct fix ?
Found out myself, that usb_unlink_urb is always async now, so URB_ASYNC_UNLINK is
really obsolete and removing the lines should be enough.
> Documentation/usb/URB.txt still point to URB_ASYNC_UNLINK for such cases.
>
Should be adapted too.
--
Karsten Keil
SuSE Labs
ISDN development
prev parent reply other threads:[~2005-09-19 14:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-09-17 21:52 Karsten Keil
2005-09-17 22:26 ` Greg KH
2005-09-19 14:21 ` Karsten Keil
2005-09-19 14:29 ` Karsten Keil [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050919142950.GA13757@pingi3.kke.suse.de \
--to=kkeil@suse.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®