From: Christoph Hellwig <hch@infradead.org>
To: Pantelis Antoniou <pantelis@embeddedalley.com>
Cc: rmk+serial@arm.linux.org.uk, linux-kernel@vger.kernel.org,
cw@f00f.org, Pete Popov <ppopov@embeddedalley.com>,
Matt Porter <mporter@embeddedalley.com>
Subject: Re: [PATCH] Au1x00 8250 uart support.
Date: Mon, 19 Sep 2005 21:44:54 +0100 [thread overview]
Message-ID: <20050919204454.GA30041@infradead.org> (raw)
In-Reply-To: <200509192340.10450.pantelis@embeddedalley.com>
> static _INLINE_ unsigned int serial_in(struct uart_8250_port *up, int offset)
> {
> +#ifdef CONFIG_SERIAL_8250_AU1X00
> + if (up->port.iotype == UPIO_AU)
> + offset = au_io_in_map[offset];
> +#endif
All this ifdef stuff is rather messy. Allowing the driver to specity a map
in some structure might make more sense.
next prev parent reply other threads:[~2005-09-19 20:44 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-09-19 20:40 Pantelis Antoniou
2005-09-19 20:44 ` Christoph Hellwig [this message]
2005-09-19 20:53 ` Pantelis Antoniou
2005-09-19 20:58 ` Chris Wedgwood
2005-09-20 16:37 ` Russell King
2005-09-20 17:50 ` [PATCH] Au1x00 8250 uart support (Updated) Pantelis Antoniou
2005-09-21 7:11 ` Russell King
2005-09-21 16:14 ` [PATCH] Au1x00 8250 uart support (Updated - take #2) Pantelis Antoniou
2005-09-21 19:17 ` Russell King
2005-09-21 19:36 ` [PATCH] Au1x00 8250 uart support (Updated - take #3) Pantelis Antoniou
2005-09-22 19:11 ` [PATCH] Au1x00 8250 uart support (Updated - take #4) Pantelis Antoniou
2005-11-06 8:44 ` Russell King
2005-11-06 9:02 ` Pantelis Antoniou
2005-11-06 9:07 ` Russell King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050919204454.GA30041@infradead.org \
--to=hch@infradead.org \
--cc=cw@f00f.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mporter@embeddedalley.com \
--cc=pantelis@embeddedalley.com \
--cc=ppopov@embeddedalley.com \
--cc=rmk+serial@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®