From: Denis Vlasenko <vda@ilport.com.ua>
To: "colin" <colin@realtek.com.tw>
Cc: linux-kernel@vger.kernel.org
Subject: Re: CONFIG_PRINTK doesn't makes size smaller
Date: Tue, 20 Sep 2005 11:30:10 +0300 [thread overview]
Message-ID: <200509201130.10905.vda@ilport.com.ua> (raw)
In-Reply-To: <01bf01c5bdaa$9e8b81c0$106215ac@realtek.com.tw>
On Tuesday 20 September 2005 09:14, colin wrote:
>
> Hi there,
> I tried to make kernel with CONFIG_PRINTK off. I considered it should become
> smaller, but it didn't because it actually isn't an empty function, and
> there are many copies of it in vmlinux, not just one. Here is its
> definition:
> static inline int printk(const char *s, ...) { return 0; }
>
> I change the definition to this and it can greatly reduce the size by about
> 5%:
> #define printk(...) do {} while (0)
> However, this definition would lead to error in some situations. For
> example:
> 1. (printk)
> 2. ret = printk
>
> I hope someone could suggest a better definition of printk that can both
> make printk smaller and eliminate errors.
I think isolated testcase (a preprocessed .c file) would be interesting.
Use make dir/dir/file.i, reduce result to small .c file which shows
the problem, and show it on lkml.
--
vda
prev parent reply other threads:[~2005-09-20 8:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-09-20 6:14 colin
2005-09-20 6:38 ` Andrey Panin
2005-09-20 7:48 ` Vadim Lobanov
2005-09-20 8:03 ` Andrew Morton
2005-09-20 9:11 ` colin
2005-09-20 9:02 ` Andrey Panin
2005-09-20 15:41 ` Vadim Lobanov
2005-09-20 8:30 ` Denis Vlasenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200509201130.10905.vda@ilport.com.ua \
--to=vda@ilport.com.ua \
--cc=colin@realtek.com.tw \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®