mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Siddha, Suresh B" <suresh.b.siddha@intel.com>
To: Andrew Morton <akpm@osdl.org>
Cc: "Siddha, Suresh B" <suresh.b.siddha@intel.com>,
	venkatesh.pallipadi@intel.com, linux-kernel@vger.kernel.org
Subject: Re: [patch] intel_cacheinfo: remove MAX_CACHE_LEAVES limit
Date: Tue, 20 Sep 2005 17:58:44 -0700	[thread overview]
Message-ID: <20050920175843.A31499@unix-os.sc.intel.com> (raw)
In-Reply-To: <20050920160604.5e022fa8.akpm@osdl.org>; from akpm@osdl.org on Tue, Sep 20, 2005 at 04:06:04PM -0700

On Tue, Sep 20, 2005 at 04:06:04PM -0700, Andrew Morton wrote:
> "Siddha, Suresh B" <suresh.b.siddha@intel.com> wrote:
> >
> > Remove the MAX_CACHE_LEAVES limit from the routine which calculates the
> > number of cache levels using cpuid(4)
> 
> Why?  Why was the code there originally, and why is it required that it be
> removed, and why is it safe to remove it?
> 
> (IOW: your description of this patch is inadequate: it describes what was
> done, but not why it was done).

oops! Initial internal version of Venki's cpuid(4) deterministic cache
parameter identification patch used static arrays of size MAX_CACHE_LEAVES. 
Final patch which made to the base used dynamic array allocation, with this
MAX_CACHE_LEAVES limit hunk still in place. 

cpuid(4) already has a mechanism to find out the number of cache levels
implemented and there is no need for this hardcoded MAX_CACHE_LEAVES limit.

thanks,
suresh

      reply	other threads:[~2005-09-21  0:58 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-09-19 19:14 Siddha, Suresh B
2005-09-20 23:06 ` Andrew Morton
2005-09-21  0:58   ` Siddha, Suresh B [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050920175843.A31499@unix-os.sc.intel.com \
    --to=suresh.b.siddha@intel.com \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=venkatesh.pallipadi@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome