From: Andrew Morton <akpm@osdl.org>
To: Ashok Raj <ashok.raj@intel.com>
Cc: linux-kernel@vger.kernel.org, ak@muc.de,
suresh.b.siddha@intel.com, discuss@x86-64.org
Subject: Re: init and zap low address mappings on demand for cpu hotplug
Date: Wed, 21 Sep 2005 14:11:57 -0700 [thread overview]
Message-ID: <20050921141157.1bd7aa94.akpm@osdl.org> (raw)
In-Reply-To: <20050921135731.B14439@unix-os.sc.intel.com>
Ashok Raj <ashok.raj@intel.com> wrote:
>
> +/*
> + * mode
> + * 0 indicates its for __cpu_up to kick an AP into boot sequence.
> + * 1 indicates completion os smp boot process, so we can zap the low
> + * until there is need to bring a cpu up again.
> + */
> +__cpuinit void zap_low_mappings(int mode)
grump. `mode' is a terrible identifier name. Better to call it something
which identifies its meaning if true, such as `do_mapping_zapping' or
something.
Even better, implement two nicely-named functions rather than passing in a
`mode' argument. Those functions can of course share a common
mode-selected implementation internally.
And that comment is incomprehensible, partly due to all its typos. Care to
try again?
next prev parent reply other threads:[~2005-09-21 21:12 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-09-21 20:57 Ashok Raj
2005-09-21 21:11 ` Andrew Morton [this message]
2005-09-21 22:39 ` Ashok Raj
2005-09-22 9:48 ` Andi Kleen
2005-09-24 0:28 ` Siddha, Suresh B
2005-09-26 6:58 ` Andi Kleen
2005-09-26 23:19 ` Siddha, Suresh B
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050921141157.1bd7aa94.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=ak@muc.de \
--cc=ashok.raj@intel.com \
--cc=discuss@x86-64.org \
--cc=linux-kernel@vger.kernel.org \
--cc=suresh.b.siddha@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®