From: "Randy.Dunlap" <rdunlap@xenotime.net>
To: Len Brown <len.brown@intel.com>
Cc: zippel@linux-m68k.org, viro@ZenIV.linux.org.uk,
Eric.Piel@lifl.fr, torvalds@osdl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] bogus #if (acpi/blacklist)
Date: Wed, 21 Sep 2005 22:14:26 -0700 [thread overview]
Message-ID: <20050921221426.7ccdeac7.rdunlap@xenotime.net> (raw)
In-Reply-To: <1126821915.31252.10.camel@toshiba>
On Thu, 15 Sep 2005 18:05:15 -0400 Len Brown wrote:
> On Fri, 2005-09-09 at 12:55 -0400, Roman Zippel wrote:
> > Hi,
> >
> > On Fri, 9 Sep 2005 viro@ZenIV.linux.org.uk wrote:
> >
> > > Sigh... It should be left as #if, of course, but I suspect that
> > cleaner way to
> > > deal with that would be (in Kconfig)
> > >
> > > config ACPI_BLACKLIST_YEAR
> > > int "Disable ACPI for systems before Jan 1st this year" if
> > X86
> > > default 0
> >
> > That would be indeed the better fix.
>
> The real bug is that drivers/acpi/blacklist.c (the only place
> CONFIG_ACPI_BLACLIST_YEAR is referenced) is compiled for non X86.
You want this then?
---
From: Randy Dunlap <rdunlap@xenotime.net>
Only build drivers/acpi/blacklist.o on X86 (includes X86_64).
Signed-off-by: Randy Dunlap <rdunlap@xenotime.net>
---
drivers/acpi/Makefile | 2 ++
1 files changed, 2 insertions(+)
diff -Naurp linux-2614-rc2/drivers/acpi/Makefile~blacklist_x86 linux-2614-rc2/drivers/acpi/Makefile
--- linux-2614-rc2/drivers/acpi/Makefile~blacklist_x86 2005-09-21 22:11:23.000000000 -0700
+++ linux-2614-rc2/drivers/acpi/Makefile 2005-09-21 22:11:41.000000000 -0700
@@ -16,7 +16,9 @@ EXTRA_CFLAGS += $(ACPI_CFLAGS)
# ACPI Boot-Time Table Parsing
#
obj-y += tables.o
+ifdef CONFIG_X86
obj-y += blacklist.o
+endif
#
# ACPI Core Subsystem (Interpreter)
---
next prev parent reply other threads:[~2005-09-22 5:14 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-09-09 16:07 viro
2005-09-09 16:19 ` Eric Piel
2005-09-09 16:43 ` viro
2005-09-09 16:55 ` Roman Zippel
2005-09-09 17:31 ` viro
2005-09-15 22:05 ` Len Brown
2005-09-22 5:14 ` Randy.Dunlap [this message]
2005-09-22 5:15 ` Al Viro
2005-09-22 5:50 Brown, Len
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050921221426.7ccdeac7.rdunlap@xenotime.net \
--to=rdunlap@xenotime.net \
--cc=Eric.Piel@lifl.fr \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
--cc=viro@ZenIV.linux.org.uk \
--cc=zippel@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®