mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@osdl.org>
To: Ivan Kokshaysky <ink@jurassic.park.msu.ru>
Cc: Brice.Goglin@ens-lyon.org, linux-kernel@vger.kernel.org, rth@twiddle.net
Subject: Re: Kernel panic during SysRq-b on Alpha
Date: Thu, 22 Sep 2005 02:21:52 -0700	[thread overview]
Message-ID: <20050922022152.0c0f0c97.akpm@osdl.org> (raw)
In-Reply-To: <20050922130449.A29503@jurassic.park.msu.ru>

Ivan Kokshaysky <ink@jurassic.park.msu.ru> wrote:
>
> On Wed, Sep 21, 2005 at 11:42:32PM -0700, Andrew Morton wrote:
> > Wow, never seen that done before.  Does it actually work?  For keyboard,
> > serial console and /proc/sysrq-trigger?
> 
> Yes, all of this works for me.
> 
> There is another problem on Alpha with 2.6.14-rc kernels, much worse:
> slab.c:index_of() works _only_ when it's really inlined, because of
> __builtin_constant_p() check. It happens to work on other archs
> due to "always_inline" alchemy in compiler.h, but on Alpha we undo 
> the "inline" redefinitions as they heavily break our internal stuff.
> So the slab.c blows up very early on boot (at least when compiled
> with gcc3).

hm, you might need to do some special-casing around that function.

> I'd be happy if it is possible to stop global redefining of "inline"
> keywords and just use __attribute__((always_inline)) when needed.
> If not, I don't know how to fix that cleanly.

We did that because gcc 3.3 (iirc) was utterly buggered.  I forget what it
was doing exactly - generating out-of-line copies in various compilation
units, using more stack space as a result.  That workaround shrunk typical
x86 kernels by ~64k.

If recent gcc's have a -fdont-be-so-damn-stupid option we could use that.


  reply	other threads:[~2005-09-22  9:22 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-09-21 13:11 Brice Goglin
2005-09-22  6:12 ` Ivan Kokshaysky
2005-09-22  6:42   ` Andrew Morton
2005-09-22  9:04     ` Ivan Kokshaysky
2005-09-22  9:21       ` Andrew Morton [this message]
2005-09-22 10:34         ` Ivan Kokshaysky
2005-09-22 10:13       ` Brice Goglin
2005-09-22 10:42         ` Ivan Kokshaysky
2005-09-23 22:03         ` Ivan Kokshaysky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050922022152.0c0f0c97.akpm@osdl.org \
    --to=akpm@osdl.org \
    --cc=Brice.Goglin@ens-lyon.org \
    --cc=ink@jurassic.park.msu.ru \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rth@twiddle.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®