From: Andrew Morton <akpm@osdl.org>
To: <Abhay_Salunke@Dell.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: FW: [patch 2.6.14-rc2] dell_rbu: changes in packet update mechanism
Date: Fri, 23 Sep 2005 12:44:51 -0700 [thread overview]
Message-ID: <20050923124451.61694274.akpm@osdl.org> (raw)
In-Reply-To: <597A2BC19EDD3C458F841E8724E92D4B973E19@ausx3mps301.aus.amer.dell.com>
<Abhay_Salunke@Dell.com> wrote:
>
> -static ssize_t write_rbu_image_type(struct kobject *kobj, char *buffer,
> - loff_t pos, size_t count)
> +static ssize_t
> +write_rbu_image_type(struct kobject *kobj, char *buffer, loff_t pos,
This is contrary to the conventional kernel coding style. I suggest you
not include all these layout changes.
next prev parent reply other threads:[~2005-09-23 19:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-09-23 19:08 Abhay_Salunke
2005-09-23 19:18 ` Randy.Dunlap
2005-09-23 19:44 ` Andrew Morton [this message]
2005-09-26 16:07 ` Abhay Salunke
2005-09-23 19:23 Abhay_Salunke
2005-09-23 20:27 Abhay_Salunke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050923124451.61694274.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=Abhay_Salunke@Dell.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®