From: Karsten Wiese <annabellesgarden@yahoo.de>
To: Clemens Ladisch <clemens@ladisch.de>
Cc: linux-kernel@vger.kernel.org, Bob Picco <bob.picco@hp.com>,
Ingo Molnar <mingo@elte.hu>
Subject: Re: [PATCH 2/2] HPET: make frequency calculations 32 bit safe
Date: Sat, 24 Sep 2005 01:46:22 +0200 [thread overview]
Message-ID: <200509240146.22715.annabellesgarden@yahoo.de> (raw)
> --- linux-2.6.13.orig/drivers/char/hpet.c 2005-09-22 11:10:01.000000000 +0200
> +++ linux-2.6.13/drivers/char/hpet.c 2005-09-22 12:08:48.000000000 +0200
> @@ -78,7 +78,7 @@ struct hpets {
> struct hpet __iomem *hp_hpet;
> unsigned long hp_hpet_phys;
> struct time_interpolator *hp_interpolator;
> - unsigned long hp_period;
> + unsigned long long hp_tick_freq;
An 'unsigned long' is enough.
Are we expecting hpets stepping at more than 4GHz?
They are called 'legacy' in some docs already ;-)
Here the via8237's hpet runs at ~14MHz.
> unsigned long hp_delta;
> unsigned int hp_ntimer;
> unsigned int hp_which;
Tested OK on i386 2.6.13-rt14 with above nitpick applied.
Karsten
___________________________________________________________
Gesendet von Yahoo! Mail - Jetzt mit 1GB Speicher kostenlos - Hier anmelden: http://mail.yahoo.de
next reply other threads:[~2005-09-23 23:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-09-23 23:46 Karsten Wiese [this message]
2005-09-26 7:30 ` Clemens Ladisch
-- strict thread matches above, loose matches on Subject: below --
2005-09-22 15:08 [PATCH 1/2] HPET: disallow zero interrupt frequency Clemens Ladisch
2005-09-22 15:08 ` [PATCH 2/2] HPET: make frequency calculations 32 bit safe Clemens Ladisch
2005-09-27 14:57 ` Bob Picco
2005-09-30 6:30 ` Clemens Ladisch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200509240146.22715.annabellesgarden@yahoo.de \
--to=annabellesgarden@yahoo.de \
--cc=bob.picco@hp.com \
--cc=clemens@ladisch.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®