From: "Jörn Engel" <joern@wohnheim.fh-wedel.de>
To: Jesper Juhl <jesper.juhl@gmail.com>
Cc: Vadim Lobanov <vlobanov@speakeasy.net>,
akpm@osdl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Unify sys_tkill() and sys_tgkill()
Date: Sat, 24 Sep 2005 18:38:18 +0200 [thread overview]
Message-ID: <20050924163818.GA7339@wohnheim.fh-wedel.de> (raw)
In-Reply-To: <9a8748490509240752436ef7b2@mail.gmail.com>
On Sat, 24 September 2005 16:52:28 +0200, Jesper Juhl wrote:
>
> [snip]
> > +static int do_tkill(int tgid, int pid, int sig)
>
> I would probably have made this
>
> static inline int do_tkill(int tgid, int pid, int sig)
Why? It would only return the original duplication in binary form and
save a minimal amount of time for something already slow - a system
call. With small caches, the code duplication could even waste more
performance than the missing function call would gain you.
Other nits were well-picked.
Jörn
--
You can't tell where a program is going to spend its time. Bottlenecks
occur in surprising places, so don't try to second guess and put in a
speed hack until you've proven that's where the bottleneck is.
-- Rob Pike
next prev parent reply other threads:[~2005-09-24 16:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-09-24 2:18 Vadim Lobanov
2005-09-24 14:52 ` Jesper Juhl
2005-09-24 16:03 ` Serious time drift - clock running fast Howard Chu
2005-09-24 16:38 ` Jörn Engel [this message]
2005-09-24 19:15 ` [PATCH] Unify sys_tkill() and sys_tgkill() Jesper Juhl
2005-09-24 17:47 ` Vadim Lobanov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050924163818.GA7339@wohnheim.fh-wedel.de \
--to=joern@wohnheim.fh-wedel.de \
--cc=akpm@osdl.org \
--cc=jesper.juhl@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=vlobanov@speakeasy.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®