From: Pierre Ossman <drzeus@drzeus.cx>
To: rmk+lkml@arm.linux.co.uk
Cc: Pierre Ossman <drzeus-list@drzeus.cx>
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH] [MMC] wbsd: use dma_alloc insted of kmalloc
Date: Sun, 25 Sep 2005 21:16:23 +0200 [thread overview]
Message-ID: <20050925191614.23944.2485.stgit@poseidon.drzeus.cx> (raw)
x86_64 doesn't seem to like being passed pointers allocated using
kmalloc to the DMA mapping API. Change allocation to use
dma_alloc_coherent() instead.
Signed-off-by: Pierre Ossman <drzeus@drzeus.cx>
---
drivers/mmc/wbsd.c | 26 +++++++++++---------------
1 files changed, 11 insertions(+), 15 deletions(-)
diff --git a/drivers/mmc/wbsd.c b/drivers/mmc/wbsd.c
--- a/drivers/mmc/wbsd.c
+++ b/drivers/mmc/wbsd.c
@@ -1543,18 +1543,17 @@ static void __devinit wbsd_request_dma(s
* We need to allocate a special buffer in
* order for ISA to be able to DMA to it.
*/
- host->dma_buffer = kmalloc(WBSD_DMA_SIZE,
+
+ mmc_dev(host->mmc)->coherent_dma_mask = 0xffffff;
+ mmc_dev(host->mmc)->dma_mask = &mmc_dev(host->mmc)->coherent_dma_mask;
+
+ host->dma_buffer = dma_alloc_coherent(mmc_dev(host->mmc),
+ WBSD_DMA_SIZE, &host->dma_addr,
GFP_NOIO | GFP_DMA | __GFP_REPEAT | __GFP_NOWARN);
if (!host->dma_buffer)
goto free;
/*
- * Translate the address to a physical address.
- */
- host->dma_addr = dma_map_single(host->mmc->dev, host->dma_buffer,
- WBSD_DMA_SIZE, DMA_BIDIRECTIONAL);
-
- /*
* ISA DMA must be aligned on a 64k basis.
*/
if ((host->dma_addr & 0xffff) != 0)
@@ -1575,12 +1574,11 @@ kfree:
*/
BUG_ON(1);
- dma_unmap_single(host->mmc->dev, host->dma_addr, WBSD_DMA_SIZE,
- DMA_BIDIRECTIONAL);
- host->dma_addr = (dma_addr_t)NULL;
+ dma_free_coherent(mmc_dev(host->mmc), WBSD_DMA_SIZE,
+ host->dma_buffer, host->dma_addr);
- kfree(host->dma_buffer);
host->dma_buffer = NULL;
+ host->dma_addr = (dma_addr_t)NULL;
free:
free_dma(dma);
@@ -1592,11 +1590,9 @@ err:
static void __devexit wbsd_release_dma(struct wbsd_host* host)
{
- if (host->dma_addr)
- dma_unmap_single(host->mmc->dev, host->dma_addr, WBSD_DMA_SIZE,
- DMA_BIDIRECTIONAL);
if (host->dma_buffer)
- kfree(host->dma_buffer);
+ dma_free_coherent(mmc_dev(host->mmc), WBSD_DMA_SIZE,
+ host->dma_buffer, host->dma_addr);
if (host->dma >= 0)
free_dma(host->dma);
next reply other threads:[~2005-09-25 19:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-09-25 19:16 Pierre Ossman [this message]
2005-09-25 19:29 ` Christoph Hellwig
2005-09-25 19:37 ` Pierre Ossman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050925191614.23944.2485.stgit@poseidon.drzeus.cx \
--to=drzeus@drzeus.cx \
--cc=drzeus-list@drzeus.cx \
--cc=rmk+lkml@arm.linux.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome