From: "Jörn Engel" <joern@wohnheim.fh-wedel.de>
To: Linus Torvalds <torvalds@osdl.org>
Cc: Deepak Saxena <dsaxena@plexity.net>,
linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Fix IXP4xx MTD driver no cast warning
Date: Fri, 30 Sep 2005 01:02:23 +0200 [thread overview]
Message-ID: <20050929230222.GA30887@wohnheim.fh-wedel.de> (raw)
In-Reply-To: <Pine.LNX.4.58.0509291259110.3308@g5.osdl.org>
On Thu, 29 September 2005 13:00:18 -0700, Linus Torvalds wrote:
> On Thu, 29 Sep 2005, Deepak Saxena wrote:
> >
> > drivers/mtd/maps/ixp4xx.c: In function 'ixp4xx_flash_probe':
> > drivers/mtd/maps/ixp4xx.c:199: warning: assignment makes integer from
> > pointer without a cast
>
> Please don't. The warning is entirely warranted, as far as I can tell.
>
> Shutting up warnings just because they are warnings is bad practice.
> Either fix them, or leave them be.
>
> If you do an "ioremap()", then the result is a "(void __iomem *)". If you
> assign it to something that is "unsigned long", you _should_ get a
> warning.
Code is correct, as far as this specific mapping driver is concerned.
But it would make some sense to convert one of the map_priv_[12] in
struct map_info to (void __iomem *).
Jörn
--
It does not matter how slowly you go, so long as you do not stop.
-- Confucius
next prev parent reply other threads:[~2005-09-29 23:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-09-29 19:52 Deepak Saxena
2005-09-29 20:00 ` Linus Torvalds
2005-09-29 23:02 ` Jörn Engel [this message]
2005-09-29 20:52 ` Russell King
2005-09-29 21:20 ` Deepak Saxena
2005-09-29 23:18 ` Jörn Engel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050929230222.GA30887@wohnheim.fh-wedel.de \
--to=joern@wohnheim.fh-wedel.de \
--cc=dsaxena@plexity.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®