From: Stephen Hemminger <shemminger@osdl.org>
To: linux-kernel@vger.kernel.org
Subject: Re: reiser4 compilation fix [ was: 2.6.14-rc2-mm2]
Date: Fri, 30 Sep 2005 15:23:56 -0700 [thread overview]
Message-ID: <20050930152356.35597449@dxpl.pdx.osdl.net> (raw)
In-Reply-To: <200510010202.32667.zam@namesys.com>
>
> Andrew, please add this reiser4 compilation fix :
> ---------------------------------------------------
> --- a/fs/reiser4/spin_macros.h
> +++ b/fs/reiser4/spin_macros.h
> @@ -82,8 +82,6 @@ typedef struct reiser4_rw_data {
> static inline void spin_ ## NAME ## _init(TYPE *x) \
> { \
> __ODCA("nikita-2987", x != NULL); \
> - cassert(sizeof(x->FIELD) != 0); \
> - memset(& x->FIELD, 0, sizeof x->FIELD); \
> spin_lock_init(& x->FIELD.lock); \
> } \
> \
> @@ -236,7 +234,6 @@ typedef struct { int foo; } NAME ## _spi
> static inline void rw_ ## NAME ## _init(TYPE *x) \
> { \
> __ODCA("nikita-2988", x != NULL); \
> - memset(& x->FIELD, 0, sizeof x->FIELD); \
> rwlock_init(& x->FIELD.lock); \
> } \
> \
These are just the kind of bogus macro's that block reiser4 from
getting merged.
--
Stephen Hemminger <shemminger@osdl.org>
OSDL http://developer.osdl.org/~shemminger
next prev parent reply other threads:[~2005-09-30 22:23 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-09-29 21:37 2.6.14-rc2-mm2 Andrew Morton
2005-09-29 21:46 ` 2.6.14-rc2-mm2 Alexandre Buisse
2005-09-29 22:51 ` 2.6.14-rc2-mm2 Michal Piotrowski
2005-09-29 23:00 ` 2.6.14-rc2-mm2 Aurelien Francillon
2005-09-29 22:56 ` 2.6.14-rc2-mm2 Andrew Morton
2005-09-29 22:08 ` 2.6.14-rc2-mm2 Alexandre Buisse
2005-09-29 23:40 ` 2.6.14-rc2-mm2 Michal Piotrowski
2005-09-29 23:54 ` 2.6.14-rc2-mm2 Brice Goglin
2005-09-30 8:45 ` 2.6.14-rc2-mm2 Laurent Riffard
2005-09-30 9:20 ` 2.6.14-rc2-mm2 Alexander Zarochentsev
2005-09-30 10:10 ` 2.6.14-rc2-mm2 Laurent Riffard
2005-09-29 23:51 ` 2.6.14-rc2-mm2 Hans Reiser
2005-09-29 22:47 ` 2.6.14-rc2-mm2 Michal Piotrowski
2005-09-29 23:18 ` 2.6.14-rc2-mm2 Antonino A. Daplas
2005-09-29 23:25 ` 2.6.14-rc2-mm2 Andrew Morton
2005-09-29 23:45 ` 2.6.14-rc2-mm2 Antonino A. Daplas
2005-09-29 23:47 ` 2.6.14-rc2-mm2 Michal Piotrowski
2005-09-29 23:48 ` 2.6.14-rc2-mm2 Grant Coady
2005-09-29 23:27 ` 2.6.14-rc2-mm2 Michal Piotrowski
2005-09-29 23:09 ` 2.6.14-rc2-mm2 J.A. Magallon
2005-09-30 2:16 ` 2.6.14-rc2-mm2 Grant Coady
2005-10-01 18:16 ` 2.6.14-rc2-mm2 Jean Delvare
2005-09-29 23:26 ` 2.6.14-rc2-mm2 Mark Knecht
2005-09-29 23:49 ` 2.6.14-rc2-mm2 Andrew Morton
2005-09-29 23:58 ` 2.6.14-rc2-mm2 Mark Knecht
2005-09-30 10:06 ` [PATCH -mm] s390: fix TIMER_MAGIC breakage Alexey Dobriyan
2005-09-30 14:36 ` 2.6.14-rc2-mm2 Martin J. Bligh
2005-09-30 16:54 ` 2.6.14-rc2-mm2 Badari Pulavarty
2005-09-30 17:15 ` 2.6.14-rc2-mm2 Grant Wilson
2005-09-30 18:49 ` 2.6.14-rc2-mm2 (PHY reset until link up) Dominik Karall
2005-09-30 19:07 ` Andrew Morton
2005-09-30 19:32 ` [patch 2.6.14-rc2 1/1] r8169: tone down the r8169 driver Francois Romieu
2005-09-30 20:15 ` 2.6.14-rc2-mm2 (PHY reset until link up) Francois Romieu
2005-09-30 19:36 ` 2.6.14-rc2-mm2 Mickael Marchand
2005-10-04 21:42 ` 2.6.14-rc2-mm2 Mickael Marchand
2005-09-30 19:56 ` 2.6.14-rc2-mm2 alexs
2005-09-30 22:02 ` reiser4 compilation fix [ was: 2.6.14-rc2-mm2] Alexander Zarochentsev
2005-09-30 22:23 ` Stephen Hemminger [this message]
2005-10-01 4:56 ` [PATCH] mips: add missing semicolon Yoichi Yuasa
2005-10-01 16:52 ` 2.6.14-rc2-mm2 (dma_timer_expiry) Dominik Karall
2005-10-02 20:06 ` 2.6.14-rc2-mm2 (NULL pointer) Dominik Karall
2005-10-02 20:45 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050930152356.35597449@dxpl.pdx.osdl.net \
--to=shemminger@osdl.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®