mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Pete Zaitcev <zaitcev@redhat.com>
To: Christopher Li <usb-devel@chrisli.org>
Cc: chrisl@vmware.com, linux-usb-devel@lists.sourceforge.net,
	linux-kernel@vger.kernel.org, zaitcev@redhat.com
Subject: Re: PATCH] incrase usbdevfs bulk buffer size
Date: Sun, 2 Oct 2005 21:10:14 -0700	[thread overview]
Message-ID: <20051002211014.195ff1c3.zaitcev@redhat.com> (raw)
In-Reply-To: <20051002193422.GH3453@64m.dyndns.org>

On Sun, 2 Oct 2005 15:34:22 -0400, Christopher Li <usb-devel@chrisli.org> wrote:

> > 16K is an order 2 allocation on systems with 4KB pages, such as
> > Opteron. It kinda sorta works, but not really.
> > 
> > This looks like a requirement to think about a better API. []
> 
> I think the API is kind of fine in this aspect. The usbdevfs should be
> able to take bigger than 16K, but the internal copy of the urb does not
> have to use kmalloc on data buffers.

You miss an important detail here, namely that single URBs do not have
a capability to transfer to a discotiguous buffer. As long as you try
to map one transfer insive VMware to one URB, one and only one kmalloc
has to be done. But if splitting the transfer is acceptable, there is
no reason to up the maximum buffer size in usbfs. But the above is IMHO
only, and perhaps I miss something as well.

-- Pete

  reply	other threads:[~2005-10-03  4:10 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-10-01 20:20 [PATCH] " Christopher Li
2005-10-02 22:08 ` PATCH] " Pete Zaitcev
2005-10-02 19:34   ` Christopher Li
2005-10-03  4:10     ` Pete Zaitcev [this message]
2005-10-03  3:05       ` Christopher Li

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20051002211014.195ff1c3.zaitcev@redhat.com \
    --to=zaitcev@redhat.com \
    --cc=chrisl@vmware.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb-devel@lists.sourceforge.net \
    --cc=usb-devel@chrisli.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome