From: Paul Jackson <pj@sgi.com>
To: Magnus Damm <magnus.damm@gmail.com>
Cc: torvalds@osdl.org, akpm@osdl.org, jgarzik@pobox.com,
rdunlap@xenotime.net, linux-kernel@vger.kernel.org,
coywolf@gmail.com, greg@kroah.com
Subject: Re: [PATCHv2] Document from line in patch format
Date: Mon, 3 Oct 2005 20:38:26 -0700 [thread overview]
Message-ID: <20051003203826.514ea047.pj@sgi.com> (raw)
In-Reply-To: <aec7e5c30510032024t6d48643fma875c917acb69d92@mail.gmail.com>
Magnus wrote:
> Huh, I thought that the first line in a unified patch started with
> "---",
Yes, it does. But then the next character is a space, and there
is at least one more space-separated field on the line.
That is, Linus's marker marches
/^---$/
and the first line of a unified patch matches:
/^--- .*[^ ].*$/
It ain't fancy, but it works. These patterns
are easily distinguished.
> Relying on "diff -" or "Index: " seems wrong.
I don't think anyone is relying on those patterns.
--
I won't rest till it's the best ...
Programmer, Linux Scalability
Paul Jackson <pj@sgi.com> 1.925.600.0401
next prev parent reply other threads:[~2005-10-04 3:39 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-10-02 16:32 Paul Jackson
2005-10-02 19:04 ` Linus Torvalds
2005-10-02 19:51 ` Paul Jackson
2005-10-04 3:24 ` Magnus Damm
2005-10-04 3:38 ` Paul Jackson [this message]
2005-10-04 4:55 ` Magnus Damm
2005-10-04 15:22 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051003203826.514ea047.pj@sgi.com \
--to=pj@sgi.com \
--cc=akpm@osdl.org \
--cc=coywolf@gmail.com \
--cc=greg@kroah.com \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=rdunlap@xenotime.net \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome