On Thursday 06 October 2005 11:20, Greg KH wrote:
> > +             printk(KERN_ERR" misc_register retruns %d \n", ret);
> > +             ret =  -EBUSY;
> > +             goto out3;
> > +     }
> > +     class = tlclk_miscdev.class;
> > +     class_device_create_file(class, &class_device_attr_current_ref);
> 
> Try registering a whole attribute group instead.  It's much nicer than
> the 20 lines you have to register and unregister your devices (and you
> don't handle the error condition properly if something goes wrong half
> way through.)
> 

I couldn't find such an API that wasn't static to class.c, or described in class.txt.  Any pointers on this would be helpful.


> > diff -urN -X dontdiff linux-2.6.14-rc2-mm2/drivers/char/tlclk.h linux-2.6.14-rc2-mm2-tlclk/drivers/char/tlclk.h
> 
> Why not just put this stuff into the tlclk.c file itself, as it isn't
> needed anywhere else?
> 
done.

Attached is an update that I think addresses your other comments.

Thanks for looking at this.

-- 
--mgross
BTW: This may or may not be the opinion of my employer, more likely not.