mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Chen, Kenneth W" <kenneth.w.chen@intel.com>
To: "'Jon Burgess'" <jburgess@uklinux.net>
Cc: "Andi Kleen" <ak@suse.de>, <linux-kernel@vger.kernel.org>,
	<linux-netdev@vger.kernel.org>
Subject: RE: kernel performance update - 2.6.14-rc3
Date: Fri, 7 Oct 2005 18:38:24 -0700	[thread overview]
Message-ID: <200510080138.j981cOg04614@unix-os.sc.intel.com> (raw)
In-Reply-To: <434717B7.30505@uklinux.net>

Jon Burgess wrote on Friday, October 07, 2005 5:50 PM
> "Chen, Kenneth W" <kenneth.w.chen@intel.com> writes:
> > Even though
> > softirq is invoked at the end of dev_queue_xmit() via local_bh_enable(),
> > not all execution of softirq will result a __wake_up().  With higher
> > HZ rate, timer interrupt is more frequent and thus more softirq
> > invocation and leads to more __wake_up(), which then takes us to higher
> > throughput because cpu spend less time in idle.
> 
> Since the loopback xmit->rx path probably isn't being called in 
> interrupt context might something like the patch below be needed?
> 
> Please forgive me if this is wrong, i've not even tried compiling
> this change let alone tested it.

I don't think this patch has any effect.  dev_queue_xmit turns off
local_bh when calling loopback_xmit, so calls to do_softirq from
netif_rx_ni Will be a noop since do_softirq immediately return upon
seeing in_interrupt().

- Ken


  reply	other threads:[~2005-10-08  1:38 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-10-08  0:49 Jon Burgess
2005-10-08  1:38 ` Chen, Kenneth W [this message]
  -- strict thread matches above, loose matches on Subject: below --
2005-10-05 21:15 Chen, Kenneth W
2005-10-06  6:16 ` Arjan van de Ven
2005-10-06 10:04   ` Nick Piggin
2005-10-06 18:36     ` Chen, Kenneth W
2005-10-06 19:24       ` Sonny Rao
2005-10-06 19:32         ` Chen, Kenneth W
2005-10-06 10:32 ` Andi Kleen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200510080138.j981cOg04614@unix-os.sc.intel.com \
    --to=kenneth.w.chen@intel.com \
    --cc=ak@suse.de \
    --cc=jburgess@uklinux.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®