From: Blaisorblade <blaisorblade@yahoo.it>
To: Junichi Uekawa <dancer@netfort.gr.jp>
Cc: user-mode-linux-devel@lists.sourceforge.net,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] UML TT-mode-only compile fix.
Date: Sun, 9 Oct 2005 21:26:04 +0200 [thread overview]
Message-ID: <200510092126.04881.blaisorblade@yahoo.it> (raw)
In-Reply-To: <87psqf2s9p.dancerj%dancer@netfort.gr.jp>
On Sunday 09 October 2005 07:06, Junichi Uekawa wrote:
> Hi,
>
> In today's linus's git tree, uml doesn't compile when it's configured for
> only TT-mode.
> This regression caused by:
> 8923648c125421b0fcb240cde607e2748d099ab8
> [PATCH] uml: clear SKAS0/3 flags when running in TT mode
>
> Signed-off-by: Junichi Uekawa <dancer@debian.org>
Thanks for the report and the patch, however I want to fix things a bit
differently... the thing _should_ compile anyway.
The macro is declared anyway and the var should exist anyway.
The problem is just that they aren't declared, I think. Will fix.
> diff --git a/arch/um/kernel/um_arch.c b/arch/um/kernel/um_arch.c
> --- a/arch/um/kernel/um_arch.c
> +++ b/arch/um/kernel/um_arch.c
> @@ -334,8 +334,10 @@ int linux_main(int argc, char **argv)
> add_arg(DEFAULT_COMMAND_LINE);
>
> os_early_checks();
> +#ifdef CONFIG_MODE_SKAS
> if (force_tt)
> clear_can_do_skas();
> +#endif
> mode_tt = force_tt ? 1 : !can_do_skas();
> #ifndef CONFIG_MODE_TT
> if (mode_tt) {
--
Inform me of my mistakes, so I can keep imitating Homer Simpson's "Doh!".
Paolo Giarrusso, aka Blaisorblade (Skype ID "PaoloGiarrusso", ICQ 215621894)
http://www.user-mode-linux.org/~blaisorblade
___________________________________
Yahoo! Mail: gratis 1GB per i messaggi e allegati da 10MB
http://mail.yahoo.it
next prev parent reply other threads:[~2005-10-09 19:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-10-09 5:06 Junichi Uekawa
2005-10-09 19:26 ` Blaisorblade [this message]
2005-10-09 22:47 ` [uml-devel] " Jeff Dike
2005-10-10 1:00 ` Junichi Uekawa
2005-10-09 20:00 ` [uml-devel] " Jeff Dike
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200510092126.04881.blaisorblade@yahoo.it \
--to=blaisorblade@yahoo.it \
--cc=dancer@netfort.gr.jp \
--cc=linux-kernel@vger.kernel.org \
--cc=user-mode-linux-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome