From: Andrew Vasquez <andrew.vasquez@qlogic.com>
To: Olaf Hering <olh@suse.de>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
James Bottomley <James.Bottomley@SteelEye.com>,
linux-scsi@vger.kernel.org
Subject: Re: [SCSI] qla2xxx: fix remote port timeout with qla2xxx driver
Date: Tue, 11 Oct 2005 16:31:08 -0700 [thread overview]
Message-ID: <20051011233108.GA25279@plap.qlogic.org> (raw)
In-Reply-To: <20051010170136.GA9736@suse.de>
On Mon, 10 Oct 2005, Olaf Hering wrote:
> On Mon, Oct 03, Linux Kernel Mailing List wrote:
>
> > tree e50f57f9c85bacf3fc07359b1a339432dea31a7a
> > parent 6f3a20242db2597312c50abc11f1e747c5d2326a
> > author Andrew Vasquez <andrew.vasquez@qlogic.com> Wed, 21 Sep 2005 03:32:11 -0700
> > committer James Bottomley <jejb@mulgrave.(none)> Sun, 25 Sep 2005 22:11:35 -0500
> >
> > [SCSI] qla2xxx: fix remote port timeout with qla2xxx driver
> > diff --git a/drivers/scsi/qla2xxx/qla_rscn.c b/drivers/scsi/qla2xxx/qla_rscn.c
> > --- a/drivers/scsi/qla2xxx/qla_rscn.c
> > +++ b/drivers/scsi/qla2xxx/qla_rscn.c
> > @@ -330,6 +330,8 @@ qla2x00_update_login_fcport(scsi_qla_hos
> > fcport->flags &= ~FCF_FAILOVER_NEEDED;
> > fcport->iodesc_idx_sent = IODESC_INVALID_INDEX;
> > atomic_set(&fcport->state, FCS_ONLINE);
> > + if (fcport->rport)
> > + fc_remote_port_unblock(fcport->rport);
>
>
> This patch lacks an #include, probably scsi/scsi_transport_fc.h:
>
> drivers/scsi/qla2xxx/qla_rscn.c:334: error: implicit declaration of function 'fc_remote_port_unblock'
Yes, here's a one-liner to add the proper include.
---
diff --git a/drivers/scsi/qla2xxx/qla_rscn.c b/drivers/scsi/qla2xxx/qla_rscn.c
index 1eba988..11682a2 100644
--- a/drivers/scsi/qla2xxx/qla_rscn.c
+++ b/drivers/scsi/qla2xxx/qla_rscn.c
@@ -18,6 +18,8 @@
*/
#include "qla_def.h"
+#include <scsi/scsi_transport_fc.h>
+
/**
* IO descriptor handle definitions.
*
prev parent reply other threads:[~2005-10-11 23:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200510031643.j93GhgRY023585@hera.kernel.org>
2005-10-10 17:01 ` Olaf Hering
2005-10-11 23:31 ` Andrew Vasquez [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051011233108.GA25279@plap.qlogic.org \
--to=andrew.vasquez@qlogic.com \
--cc=James.Bottomley@SteelEye.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=olh@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®